Pass schema object as pointer to symcc targets#747
Merged
Conversation
This avoid re-parsing the schema for every request environement. Signed-off-by: John Kastner <jkastner@amazon.com>
john-h-kastner-aws
force-pushed
the
lean_schema_cache
branch
from
d3964bd to
de76c24
Compare
chaluli
approved these changes
Sep 26, 2025
chaluli
approved these changes
Sep 26, 2025
katherine-hough
approved these changes
Sep 26, 2025
Contributor
Author
|
Currently have 3 hours running each of the fuzz impacted fuzz targets, so I'm pretty confident this won't break anything in the weekend test runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds and exports a new Lean function
loadProtobufSchemawhich parses a schema from protobuf and returns a lean object for that schema. This object is then passed to all the symcc lean ffi function.This avoid re-parsing the schema for every request environment.
Fixes #741. For the one slow unit I tested this on, run time is reduced from 6928ms to 562ms. Currently running effected fuzz targets locally and I haven't found any issues