Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Protobuf handling of Unknown #1286

Open
2 tasks
andrewmwells-amazon opened this issue Oct 22, 2024 · 0 comments
Open
2 tasks

Implement Protobuf handling of Unknown #1286

andrewmwells-amazon opened this issue Oct 22, 2024 · 0 comments
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice

Comments

@andrewmwells-amazon
Copy link
Contributor

Describe the improvement you'd like to request

In impl From<&Expr> for proto::Expr, the case for ExprKind::Unknown is unimplemented. This should be fixed before the protobufs feature is stabilized.

Describe alternatives you've considered

NA

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@andrewmwells-amazon andrewmwells-amazon added the internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice label Oct 22, 2024
@andrewmwells-amazon andrewmwells-amazon mentioned this issue Oct 22, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewmwells-amazon