Andrewmwells/protobufs #1277
Merged
Andrewmwells/protobufs #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Brandon Rozek <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
cdisselkoen
approved these changes
Oct 17, 2024
Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
…date Signed-off-by: Andrew Wells <[email protected]>
|
Java failure unrelated: https://github.com/cedar-policy/cedar-java/actions/runs/11450246364/job/31857349986?pr=243 |
Signed-off-by: Andrew Wells <[email protected]>
shaobo-he-aws
approved these changes
Oct 22, 2024
| } | ||
|
|
||
| #[cfg(feature = "protobufs")] | ||
| impl From<&Expr> for proto::Expr { |
There was a problem hiding this comment.
Maybe change this to TryFrom to avoid unimplemented?
There was a problem hiding this comment.
The obvious way to do this would require exposing a protobuf decode error upstream. I need to think more about the right approach, but I think this is ok for an experimental feature.
| @@ -840,6 +840,307 @@ impl std::fmt::Display for Unknown { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "protobufs")] | |||
| impl From<&proto::Expr> for Expr { | |||
| // PANIC SAFETY: experimental feature | |||
There was a problem hiding this comment.
Nit: maybe this comment should be more specific?
adpaco-aws
reviewed
Oct 22, 2024
Signed-off-by: Andrew Wells <[email protected]>
…ith Cedar schema Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
Signed-off-by: Andrew Wells <[email protected]>
shaobo-he-aws
approved these changes
Oct 22, 2024
adpaco-aws
approved these changes
Oct 23, 2024
shaobo-he-aws
added a commit
that referenced
this pull request
Nov 5, 2024
This reverts commit 6b16db5. Signed-off-by: Shaobo He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):(Updates not required, but will be made based on https://github.com/Brandon-Rozek/cedar-spec)
I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):