Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make partial evaluation more aggressive #1098

Closed
wants to merge 1 commit into from
Closed

Make partial evaluation more aggressive #1098

wants to merge 1 commit into from

Conversation

shaobo-he-aws
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws commented Jul 29, 2024 •
edited
Loading

Specifically, it now evluates <expr> [and|or] <expr> to <residual> [and|or] [<residual>|<expr>] instead of <residual> [and|or] <expr>, provided that LHS evaluates to a residual.

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

@shaobo-he-aws
Make partial evaluation more aggresive
316c6df 
Specifically, it now evluates `<expr> [and|or] <expr>` to
`<residual> [and|or] [<residual>|<expr>]` instead of `<residual> [and|or] <expr>`,
provided that LHS evaluates to a residual.

Signed-off-by: Shaobo He <[email protected]>
@cdisselkoen
Copy link
Contributor

This PR will need corresponding Lean updates once cedar-policy/cedar-spec#402 is merged.

@shaobo-he-aws
Copy link
Contributor Author

Closed for now. Will reopen when Lean model is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmwells-amazon andrewmwells-amazon andrewmwells-amazon approved these changes

@cdisselkoen cdisselkoen Awaiting requested review from cdisselkoen

@khieta khieta Awaiting requested review from khieta

@aaronjeline aaronjeline Awaiting requested review from aaronjeline

@john-h-kastner-aws john-h-kastner-aws Awaiting requested review from john-h-kastner-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaobo-he-aws @cdisselkoen @andrewmwells-amazon