simplify protobuf for tags in schema #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
adpaco-aws
approved these changes
Nov 25, 2024
john-h-kastner-aws
approved these changes
Nov 25, 2024
|
Due to #1326, this change needs to be replicated in cedar-policy-cli/protobuf_schema/Validator.proto |
cdisselkoen
added a commit
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
Merged
adpaco-aws
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the protobuf declaration for the
tagsfield in schemas.Possibly a breaking change for anyone using the protobuf representation of schemas that contain tag declarations. Protobufs is an experimental feature though, so this kind of breaking change should be expected.