-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring the ffi
module to 3.2.x
#852
Conversation
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Apparently I don't have enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks fine (pending resolution of CI failures), but it occurs to me that we never actually moved any cedar-wasm/
code back to the 3.2 release branch. Are you planning on doing that next?
Yes, I'm planning on bringing |
Signed-off-by: Craig Disselkoen <[email protected]>
It seems these warnings are not silenceable; upstream Rust issue rust-lang/rust#47238. Since we deny warnings, we'll need a workaround here. |
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
Alright, the workaround of never-denying-on- |
FYI: Java CI failures are expected pending cedar-policy/cedar-java#141, but the cedar-drt CI should pass edit: java fix also needs #855 |
…ffi-module-in-3.2.x Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
…ffi-module-in-3.2.x
Description of changes
main
has a bunch of great FFI changes that are scheduled for release in 4.0, but some users would like a 3.x-compatible version ofcedar-wasm
. Obviously, changes to the structs in thecedar_policy::frontend
module are breaking, so we can’t backport them to 3.x. But, since we are planning to renamefrontend
toffi
in 4.0 anyway, this PR proposes release the new FFI interface in theffi
module on 3.x, so that 3.2+ will have both thefrontend
andffi
modules and consumers can use either. Existing users offrontend
are not broken as there are no changes in thefrontend
module, and sincecedar-wasm
has not been released yet, there’s no harm in having it be based on theffi
interface even on 3.x.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):