Make parse_policy_or_template_to_est error for CST that aren't valid AST
#952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EST conversion does not apply the checks that we apply CST to EST conversion, and we don't want to duplicate all of them. For example, this function succeeded for expression using extension function with an incorrect call style like `"1".ip()` (cedar-policy/cedar-spec#341). Effects `policy_text_to_json` in the WASM bindings. Signed-off-by: John Kastner <[email protected]>
Signed-off-by: John Kastner <[email protected]>
|
|
||
| ### Changed | ||
|
|
||
| - Update `policyTextToJson` so that it reliably errors for all policies that |
There was a problem hiding this comment.
Are these quoted names functions?
There was a problem hiding this comment.
They're the JS binding function names from annotations like #[wasm_bindgen(js_name = "checkParseTemplate")]
cdisselkoen
approved these changes
Jun 7, 2024
Co-authored-by: Craig Disselkoen <[email protected]>
cdisselkoen
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EST conversion does not apply the checks that we apply CST to EST conversion, and we don't want to duplicate all of them. For example, this function succeeded for expression using extension function with an incorrect call style like
"1".ip()(cedar-policy/cedar-spec#341).Effects
policy_text_to_jsonin the WASM bindings.Description of changes
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):