Skip to content

Simple policy slicing#953

Closed
shaobo-he-aws wants to merge 18 commits intomainfrom
feature/shaobo/policy-slicing-opt
Closed

Simple policy slicing#953
shaobo-he-aws wants to merge 18 commits intomainfrom
feature/shaobo/policy-slicing-opt

Conversation

@shaobo-he-aws
Copy link
Copy Markdown
Contributor

@shaobo-he-aws shaobo-he-aws commented Jun 4, 2024

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

@shaobo-he-aws shaobo-he-aws marked this pull request as draft June 4, 2024 17:36
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
@michelbieleveld
Copy link
Copy Markdown

Hi looking forward to seeing this merged somewhere in the future. Was wondering if you have considered and perhaps benchmarked the unrolling of the actions and building a key <p,a,r> mapped to the <p,r> key. It will likely cost a bit more memory, but the slicer would no longer select and evaluate policies that do not match the action. Although likely the evaluation is already fast in memory.

@shaobo-he-aws
Copy link
Copy Markdown
Contributor Author

Hi looking forward to seeing this merged somewhere in the future. Was wondering if you have considered and perhaps benchmarked the unrolling of the actions and building a key <p,a,r> mapped to the <p,r> key. It will likely cost a bit more memory, but the slicer would no longer select and evaluate policies that do not match the action. Although likely the evaluation is already fast in memory.

@michelbieleveld thanks for your interest in this feature. After discussion, we concluded that this feature may not buy you much performance improvement if your policy set already fits into memory. Could you please share more info about why you want this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants