Skip to content

feat(eslint-config): use @eslintplugin/* packages #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gameroman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(eslint-config): use @eslintplugin/* packages #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"dependency-cruiser": "16.10.4",
"dotenv": "16.6.1",
"eslint": "8.57.1",
"eslint-plugin-react": "7.37.5",
"eslint-plugin-react": "npm:@eslintplugin/eslint-plugin-react@0.0.1",
"eslint-plugin-react-hooks": "4.6.2",
"eslint-plugin-unused-imports": "4.4.1",
"execa": "5.1.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@
"eslint-plugin-babel": "5.3.1",
"eslint-plugin-import-x": "4.16.2",
"eslint-plugin-jest-dom": "5.5.0",
"eslint-plugin-jsx-a11y": "6.10.2",
"eslint-plugin-jsx-a11y": "npm:@eslintplugin/eslint-plugin-jsx-a11y@0.0.3",
"eslint-plugin-prettier": "5.5.5",
"eslint-plugin-react": "7.37.5",
"eslint-plugin-react": "npm:@eslintplugin/eslint-plugin-react@0.0.1",
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Comment on lines +62 to +64
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Plugin API compatibility not verified

The existing ESLint config files make specific API calls that must be present in the replacement packages:

  • shared.js extends plugin:react/recommended — this requires @eslintplugin/eslint-plugin-react@0.0.1 to export a recommended config object under its configs property.
  • index.js extends plugin:jsx-a11y/recommended (when config.web.a11y is enabled) and directly references the rule name jsx-a11y/aria-role.

If either 0.0.x package does not export these config presets or rule names, every downstream Cedar project that runs ESLint will get a hard failure (Definition for rule 'jsx-a11y/aria-role' was not found or Cannot read properties of undefined (reading 'recommended')). The PR doesn't include any test output or CI evidence confirming that eslint --print-config resolves cleanly with these replacements in place.

"eslint-plugin-react-compiler": "19.1.0-rc.2",
"eslint-plugin-react-hooks": "4.6.2",
"prettier": "3.8.3",
Expand Down
Loading
Loading