fix(ci): log stderr when yarn cedar g secret fails on Windows#1789
Conversation
👷 Deploy request for cedarjs pending review.Visit the deploys page to approve it
|
Greptile SummaryThis PR improves CI debuggability for a recurring Windows failure by adding explicit error logging when
Confidence Score: 5/5Safe to merge — the change is narrowly scoped to error-handling around a single CI command and does not affect production code paths. The implementation is correct: ignoreReturnCode: true is forwarded through ...rest in actionsLib.mjs to getExecOutput, which always captures stdout/stderr regardless of silent: true. Keeping silent: true is intentional — it prevents the generated secret from appearing in CI logs on success while still allowing the captured output to be logged manually on failure. The Args interface updates accurately reflect the underlying @actions/exec API. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "style: fix prettier formatting in setUpT..." | Re-trigger Greptile |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 2s | View ↗ |
nx run-many -t build |
✅ Succeeded | 6s | View ↗ |
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 9s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 12s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-05-15 08:45:37 UTC
|
The changes in this PR are now available on npm. Try them out by running Or try it in a new app with |

Summary
Fixes a recurring flaky CI failure where
yarn cedar g secret --rawexits with code 1 on Windows (seen in PRs #1757, #1775, #1778, #1773) but produces no visible diagnostic output — making it impossible to debug.Root cause of the silence: the command was called with
silent: true. WhengetExecOutputfrom@actions/execthrows on a non-zero exit code, the buffered stdout/stderr are discarded — so nothing about the actual failure was ever logged.Changes
.github/actions/set-up-test-project/setUpTestProject.mtsyarn cedar g secret --rawfromsilent: truetoignoreReturnCode: truestdout+stderrbefore re-throwingArgsTypeScript interface to exposeignoreReturnCode?: booleanin options andexitCode: numberin the return type (the underlyinggetExecOutputalready supports/returns both — the interface was just incomplete)docs/implementation-plans/flaky-windows-smoke-tests-investigation.mdyarn cedar g secret --raw(notyarn install— the log interleaving is misleading)What this doesn't fix
The underlying cause of
yarn cedar g secret --rawfailing on Windows is still unknown. This PR just ensures the next failure will show the actual error output so we can diagnose it.