-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support surface-based VecGeom 2.x navigator #1422
base: develop
Are you sure you want to change the base?
Conversation
Several tests hang, to be investigated
Test summary 670 files 1 038 suites 32s ⏱️ For more details on these failures, see this check. Results for commit 582a387. ♻️ This comment has been updated with latest results. |
Without GPU on my laptop (clang 15 debug), on VecGeom ca34e35ea5fc822fcffd3c7c5d117e6bc671ce32 (reldeb), the following tests fail:
The simplest failure is just that it seems to report aa boundary when not actually hitting a boundary:
Full failure log: |
Not sure that the merge conflits in .github/workflows/build-spack.yml have been properly fixed.
@mrguilima I think we can merge this after #1652 and spack/spack#49313 are merged! I'll pull those in and update the CI when those are in. The one outstanding issue is the sensitive behavior of TestEM3 ... but we can disable that for the moment. |
Adapting Celeritas to use the latest surface-based model from VecGeom 2.x (see #1412).
The main change is to use VecGeom's
vgbrep::protonav::BVHSurfNavigator
. Since there are interface differences between this one and the volume-basedBVHNavigator
, the code-guardsVECGEOM_USE_SURF
, in analogy to AdePT.Alternatively,
VECGEOM_VERSION >= 0x020000
could be used instead, as the VecGeom 1.2.x series should always be used for volume-based navigation anyway.There are also distinct interfaces for ABBoxManager (template vs. non-template).
Note: in draft mode, as some tests currently fail. Under investigation.