Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lazy sense calculator #1576

Merged
merged 13 commits into from
Jan 20, 2025
Merged

Use lazy sense calculator #1576

merged 13 commits into from
Jan 20, 2025

Conversation

esseivaju
Copy link
Contributor

The lazy sense calculators require potentially recalculating the same sense multiple times. However, they do not use global memory so they have the potential to be faster, especially once we move to infix evaluation and short-circuiting.

I am splitting this from #1565 to test whether we see any performance improvement without short-circuiting.

@esseivaju esseivaju added orange Work on ORANGE geometry engine performance Changes for performance optimization labels Jan 14, 2025
@esseivaju esseivaju requested a review from sethrj January 14, 2025 01:13
Copy link

github-actions bot commented Jan 14, 2025

Test summary

 4 433 files   6 859 suites   15m 20s ⏱️
 1 683 tests  1 677 ✅  6 💤 0 ❌
24 092 runs  24 008 ✅ 84 💤 0 ❌

Results for commit 8308a19.

♻️ This comment has been updated with latest results.

@esseivaju
Copy link
Contributor Author

esseivaju commented Jan 14, 2025

Not sure why only that one unit test would fail 🤔

@esseivaju
Copy link
Contributor Author

Timings are essentially the same as in #1569 (comment), complex_intersect doesn't make a difference.

@esseivaju
Copy link
Contributor Author

@sethrj Do you want to merge this, or should we do everything as part of the infix eval PR?

Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esseivaju !

@sethrj sethrj merged commit e13c3ff into celeritas-project:develop Jan 20, 2025
38 checks passed
@esseivaju esseivaju deleted the lazy-sc branch January 20, 2025 22:36
@esseivaju esseivaju mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange Work on ORANGE geometry engine performance Changes for performance optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants