-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lazy sense calculator #1576
Conversation
Test summary 4 433 files 6 859 suites 15m 20s ⏱️ Results for commit 8308a19. ♻️ This comment has been updated with latest results. |
|
Timings are essentially the same as in #1569 (comment), |
@sethrj Do you want to merge this, or should we do everything as part of the infix eval PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @esseivaju !
The lazy sense calculators require potentially recalculating the same sense multiple times. However, they do not use global memory so they have the potential to be faster, especially once we move to infix evaluation and short-circuiting.
I am splitting this from #1565 to test whether we see any performance improvement without short-circuiting.