Implement discrete optical physics #1604
Conversation
…idation checks into separate file
…y require real_types
… RefactorOpticalMockTests
…tas into RefactorOpticalMockTests
…size_type instead of size_t
hhollenb
added
enhancement
Test summary 4 197 files 6 452 suites 13m 36s ⏱️ For more details on these failures, see this check. Results for commit b27891b. ♻️ This comment has been updated with latest results. |
src/celeritas/optical/PhysicsData.hh
Outdated
| return num_models > 0 && model_to_action >= 1; | ||
| } | ||
|
|
||
| //! Indicate a discrete interaction was rejected by integral method |
There was a problem hiding this comment.
| //! Indicate a discrete interaction was rejected by integral method | |
| //! Undergo a discrete interaction |
| /*! | ||
| * Access step-local (non-persistent) optical physics track data. | ||
| */ | ||
| class PhysicsStepView |
There was a problem hiding this comment.
Since optical physics is so much simpler than full EM, I'm not sure we need a separate "step" view. Let's discuss at today's meeting?
src/celeritas/optical/PhysicsData.hh
Outdated
|
|
||
| //---------------------------------------------------------------------------// | ||
| /*! | ||
| * Physics state data for a single track. |
There was a problem hiding this comment.
Nowadays we're preferring SOA rather than AOS, and I think it would be better not to blend the "persistent" (across steps) with the "temporary" (within a step) in the same data structure: can you replace this struct with two StateItems<real_type?.
src/celeritas/optical/PhysicsData.hh
Outdated
| using ValueGrid = GenericGridRecord; | ||
| using ValueGridId = OpaqueId<ValueGrid>; | ||
| using ValueTable = ItemRange<ValueGrid>; | ||
| using ValueTableId = OpaqueId<ValueTable>; |
There was a problem hiding this comment.
We should sync up with @amandalund about these. The requirements for optical will be much simpler (we'll just be using nonuniform grids I think?), so I don't think we'll even need them.
There was a problem hiding this comment.
Agreed, and yeah AFAIK only nonuniform grids.
| namespace optical | ||
| { | ||
| //---------------------------------------------------------------------------// | ||
| /*! |
There was a problem hiding this comment.
Need to add a line of documentation here and elsewhere...
| //---------------------------------------------------------------------------// | ||
| /*! | ||
| */ | ||
| struct AbsorptionExecutor |
There was a problem hiding this comment.
Maybe we should move these to a subsequent PR?
| { | ||
| return std::make_shared<MockModel>(id); | ||
| } | ||
| }; |
There was a problem hiding this comment.
It would make the file a bit easier to read if you move these classes to a separate file.
| protected: | ||
| using RngEngine = ::celeritas::test::DiagnosticRngEngine<std::mt19937>; | ||
|
|
||
| ModelId::size_type const num_models = 4; |
src/celeritas/optical/PhysicsData.hh
Outdated
| //// Data //// | ||
|
|
||
| StateItems<PhysicsTrackState> states; | ||
| Items<real_type> per_model_xs; //!< XS [track][model] |
There was a problem hiding this comment.
Since there are only ever two or three models (processes) and the track doesn't lose energy along the step, we may want to consider the tradeoff of storing this extra state data vs. recalculating the cross section on the fly in select_discrete_interaction.
Implementation of
PhysicsDataand associated views necessary to do volumetric optical physics.PhysicsParamsclosely matches the core physics version, but slimmed down just for discrete interactions. TheDiscreteSelectAction,PhysicsTrackView, andPhysicsStepViewwere implemented similarly. I've updated the hooks into the core optical classes so executors should have access to physics data.Currently only absorption and rayleigh models are implemented, and I've limited the importing of models in tests to just those two.
I've left the executor implementation empty for the moment to reduce the overall complexity of the merge. I can start working on them and adding them to this PR. I can also add some extra device tests and I/O tests for optical data.