Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ultra-simple tracking manager integration #1609

Merged
merged 18 commits into from
Feb 6, 2025

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Feb 3, 2025

Follow-on to #1606; see #1600. This defines static singleton classes used for integrating with external applications. It carefully checks usage patterns for single and MT use cases. Currently only the "tracking manager" version is implemented; a "user action" one will follow for older versions of Geant4.

@sethrj sethrj added enhancement New feature or request external Dependencies and framework-oriented features labels Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Test summary

 4 497 files   6 923 suites   13m 15s ⏱️
 1 698 tests  1 692 ✅  6 💤 0 ❌
24 285 runs  24 201 ✅ 84 💤 0 ❌

Results for commit 40cf8da.

♻️ This comment has been updated with latest results.

@sethrj sethrj force-pushed the tracking-manager-integration branch from 3d62911 to bb2bab5 Compare February 4, 2025 12:42
@sethrj sethrj marked this pull request as ready for review February 4, 2025 18:50
@sethrj sethrj force-pushed the tracking-manager-integration branch from 1ef7845 to 82267e8 Compare February 4, 2025 18:50
@sethrj sethrj requested a review from rahmans1 February 4, 2025 18:51
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @sethrj!

Co-authored-by: Amanda Lund <[email protected]>
@sethrj sethrj enabled auto-merge (squash) February 6, 2025 16:05
@sethrj sethrj merged commit 8ad89dd into celeritas-project:develop Feb 6, 2025
38 checks passed
@sethrj sethrj deleted the tracking-manager-integration branch February 12, 2025 18:09
@sethrj
Copy link
Member Author

sethrj commented Feb 12, 2025

From @whokion at #1615 (comment):

One more minor comment on TrackingManagerConstructor: this class name is confusing as it sounds like constructing a TrackingManager rather than a PhysicsConstructor. A concrete class of G4VPhysicsConstructor is meant to be added to a modular physics list, so its name may be better to contain "Physics" (this is also a common practice in all Geant4 physics constructors). So, suggested name may be OffloadEmPhysics or something similar. Also, the OffloadParticles still be included in ConstructParticle() rather than empty even though they are overloaded somewhere (where?) without any side effect, which clarifies what particles are specifically involved for this physics constructor. On the other hand, this is still purely a semantic argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external Dependencies and framework-oriented features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants