chore: add CPU features check during install and start of celestia-appd #5969
+162
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
commented
Oct 6, 2025
evan-forbes
previously approved these changes
Oct 6, 2025
rootulp
previously approved these changes
Oct 6, 2025
| If you are running this node in production, consider upgrading to a CPU with these features. | ||
|
|
||
| This node will continue to run, but may experience reduced performance for cryptographic operations. | ||
| If you need to bypass this check, use the --testing-environment flag. |
There was a problem hiding this comment.
[uber nit][not blocking] --testing-environment sounds like it could disable multiple checks like:
- this CPU check
- bbr
- override the default block time from 6 seconds to 1 second
if this check only overrides the CPU requirement, maybe it could be renamed to something more specific. For bbr we have --force-no-bbr so maybe --force-no-new-cpu.
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
rootulp
previously approved these changes
Oct 6, 2025
rootulp
reviewed
Oct 6, 2025
… into rachid/chore/cpu-features-check # Conflicts: # cmd/celestia-appd/cmd/cpu_features.go
|
was pushing to the wrong branch 🤦 |
rootulp
approved these changes
Oct 7, 2025
evan-forbes
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #5933
This probably should only be merged after we release v6 to mainnet.