-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove different ways to run abci apps - only in process is required #206
Comments
Additionally to this, we should settle on a DB backend. Options are: (cc @tzdybal) |
@liamsi, I think that the badgerV3 is the best option for present moment |
100% agree with this. Once we settle on a db we should look at optimizing for that specific DB instead of using the default. Also agree badger seems to be best. |
+1 for badger. |
I'm kinda surprised why everyone agrees on badger :-D Probably a very good sign. I'd like to better understand why badger is the best option before we decide on this. |
Description
Tendermint allows to interface with applications in different ways:
https://docs.tendermint.com/master/tutorials/go.html#built-in-app-vs-external-app
We only need to be able to run the application in process and can remove all other possibilities. While this looks like something we could easily do much later, @marbar3778 brought up a good point: namely that it would make our lives a bit easier with the e2e tests. More precisely, all different combinations (of app tests) are tested there: https://github.com/lazyledger/lazyledger-core/tree/master/test#tendermint-tests
e.g. https://github.com/lazyledger/lazyledger-core/blob/591d92bb1d1557bf9f9c3e7c7aa12be256009b4c/test/e2e/networks/ci.toml#L44
Removing some of the flexibility that tendermint provides, will make it easier for us to focus on LL and to more easily add e2e tests.
ref: #202
The text was updated successfully, but these errors were encountered: