-
Notifications
You must be signed in to change notification settings - Fork 334
perf(abci): remove mutex for CheckTx #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me (assuming we add a mutex on the cosmos-sdk side)
Do we have benchmarks yet of the impact of this change?
Oops not yet. Rachid and I tried yesterday with Talis but hit a few issues so will retry today before merging. |
Converting to draft to avoid accidental merge |
FWIW: #2299 has traces around the CAT mempool's CheckTx invocation so if we want to refactor this PR to not add a method to the Client interface, we can just use that PR (or extract the CheckTx tracing to this PR). |
We're using this config.toml to override a bunch of settings: https://gist.github.com/rootulp/e7a101a4468a68367bd6aa3f7bd08a2a in talis Update: that config.toml + my experiment didn't work because no traces were captured but Rachid re-ran the benchmarks using a different tracing mechanism which worked. |
Closes #2329
Benchmarks
Huge shout out to @rach-id for running the benchmarks for me 🙏
Tests
To do