Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(swamp/share): cover share module with swamp tests #4036

Merged
merged 9 commits into from
Jan 24, 2025
Merged

test(swamp/share): cover share module with swamp tests #4036

merged 9 commits into from
Jan 24, 2025

Conversation

vgonkivs
Copy link
Member

self-explanatory

@vgonkivs vgonkivs added area:shares Shares and samples kind:testing Related to unit tests swamp Related to Integration tests labels Jan 10, 2025
@vgonkivs vgonkivs self-assigned this Jan 10, 2025
@vgonkivs vgonkivs force-pushed the cover_share_with_swamp_tests branch from 06f683d to 6cd9e3b Compare January 10, 2025 14:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 44.89%. Comparing base (2469e7a) to head (f866058).
Report is 430 commits behind head on main.

Files with missing lines Patch % Lines
share/shwap/sample.go 0.00% 15 Missing ⚠️
blob/helper.go 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4036      +/-   ##
==========================================
+ Coverage   44.83%   44.89%   +0.05%     
==========================================
  Files         265      308      +43     
  Lines       14620    22481    +7861     
==========================================
+ Hits         6555    10093    +3538     
- Misses       7313    11305    +3992     
- Partials      752     1083     +331

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

renaynay
renaynay previously approved these changes Jan 15, 2025
View reviewed changes
nodebuilder/tests/share_test.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with me, thank you

Wondertan
Wondertan reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "unit tests" that got removed, didnt we want to move them somewhere?

nodebuilder/tests/share_test.go Show resolved Hide resolved
nodebuilder/tests/share_test.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the cover_share_with_swamp_tests branch from ad64dfa to 9f12b28 Compare January 24, 2025 10:44
@vgonkivs vgonkivs merged commit 77bcc9d into celestiaorg:main Jan 24, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@cristaloleg cristaloleg cristaloleg approved these changes

@renaynay renaynay renaynay left review comments

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@vgonkivs vgonkivs

Labels
area:shares Shares and samples kind:testing Related to unit tests swamp Related to Integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vgonkivs @codecov-commenter @cristaloleg @Wondertan @renaynay