Skip to content

Conversation

renaynay
Copy link
Member

No description provided.

hexcow and others added 17 commits September 5, 2025 11:26
`init()` was trying to add commands before variables were ready - Go didn’t like that.
moved `headerStoreReset`/`Recover` earlier, combined the three `init()`s into one, and removed repeated flag setups. 
initialization order is solid now and code reads better.
…stiaorg#4512)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hlib Kanunnikov <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hlib Kanunnikov <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…aorg#4532)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hlib Kanunnikov <[email protected]>
…g#4514)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hlib Kanunnikov <[email protected]>
@renaynay renaynay added the kind:misc Attached to miscellaneous PRs label Sep 22, 2025
@renaynay renaynay self-assigned this Sep 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/v0.27.0@7750e9d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
share/shwap/namespace_data_id.go 0.00% 10 Missing ⚠️
cmd/cel-shed/header.go 0.00% 7 Missing ⚠️
api/client/client.go 50.00% 3 Missing and 1 partial ⚠️
share/shwap/p2p/discovery/discovery.go 33.33% 4 Missing ⚠️
nodebuilder/config.go 0.00% 1 Missing ⚠️
share/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.27.0    #4577   +/-   ##
==================================================
  Coverage                   ?   35.22%           
==================================================
  Files                      ?      304           
  Lines                      ?    24286           
  Branches                   ?        0           
==================================================
  Hits                       ?     8554           
  Misses                     ?    14782           
  Partials                   ?      950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgonkivs
Copy link
Member

Lint failed

@renaynay renaynay marked this pull request as draft September 23, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants