fix(das): Implement OnDelete callback in DASer to clean up heights failed below Tail
#4693
+79
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4630
I also manually tested the PR with a destabilised fork of go-header (where I launched the syncer, determined a tail, and then spawned a routine that moved the tail by 300 headers randomly). DASer responded well to it and no failures were kept / reported after OnDelete was processed.
TODO: