Skip to content

Conversation

@renaynay
Copy link
Member

@renaynay renaynay commented Nov 12, 2025

Resolves #4630

I also manually tested the PR with a destabilised fork of go-header (where I launched the syncer, determined a tail, and then spawned a routine that moved the tail by 300 headers randomly). DASer responded well to it and no failures were kept / reported after OnDelete was processed.

TODO:

  • try to remove sleeps from test + make test better bc it sucks rn
  • merge headertest locking in go-header + release + update here

@renaynay renaynay self-assigned this Nov 12, 2025
@renaynay renaynay added kind:fix Attached to bug-fixing PRs area:das Related to DASer labels Nov 12, 2025
@renaynay renaynay force-pushed the rene/daser/ondelete branch from 85b1f85 to 7c7e4c8 Compare November 12, 2025 21:49
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.02%. Comparing base (2469e7a) to head (b60d800).
⚠️ Report is 620 commits behind head on main.

Files with missing lines Patch % Lines
das/state.go 25.00% 2 Missing and 1 partial ⚠️
das/coordinator.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4693      +/-   ##
==========================================
- Coverage   44.83%   36.02%   -8.81%     
==========================================
  Files         265      305      +40     
  Lines       14620    20506    +5886     
==========================================
+ Hits         6555     7388     +833     
- Misses       7313    12158    +4845     
- Partials      752      960     +208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renaynay renaynay force-pushed the rene/daser/ondelete branch from 7afd914 to b60d800 Compare November 21, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:das Related to DASer kind:fix Attached to bug-fixing PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

racey behaviour with tail determination between node components and go-header

2 participants