fix(pruner): rename failed gauge to prnr_failed_prunes_amount and fix description #4702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radik878
requested review from
Wondertan,
gupadhyaya,
renaynay,
vgonkivs and
walldiss
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric tracking failed prunes was implemented as an Int64ObservableGauge but named prnr_failed_counter and described as a counter, which contradicts gauge semantics and the repository’s naming conventions where counters use *_counter and gauges are named with amount/head/ts patterns. This change renames the gauge to prnr_failed_prunes_amount and updates the description to “current number of headers failed to prune,” aligning the metric name with its type and use (observing len(checkpoint.FailedHeaders)) and matching conventions used across das and discovery metrics.