-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dummy zk circuits #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
When I run celestia-prover in Docker then I can't generate a proof:
$ grpcurl -plaintext -d '{"client_id": "0x25cdbd2bf399341f8fee22ecdb06682ac81fdc37"}' localhost:50051 celestia.prover.v1.Prover/ProveStateTransition
ERROR:
Code: Unavailable
Message: error reading from server: EOF
When I run it locally it eventually panicked:
Prover Server listening on [::]:50051
thread 'main' panicked at provers/celestia-prover/src/main.rs:194:10:
PROTO_DESCRIPTOR_PATH environment variable not set: NotPresent
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
looks like that isn't in the .env
file
make setup | ||
``` | ||
|
||
1. Make sure to set `SP1_PROVER=network` in `.env` and get sp1 prover network private key from celestia 1Password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] this is kinda repeated below:
Prover network
To use the SP1 Prover Network you should also populate the
SP1_PROVER
andSP1_PRIVATE_KEY
environment variables. You can also use a.env
file for all environment variables
In a FLUP we can consolidate these two lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was still trying to see if local worked for you and then i would've removed prover network step from the required steps and would've just left this section untouched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does setting the SP1_PROVER=network
in local .env
actually impact the celestia prover running in Docker?
Question: why is trying to prove from block height 7 to 7? That seems like a no-op.
|
I was able to generate a proof using the prover network and it took 30 secs to 3 minutes 👍 Some of that time was downloading artifacts so maybe it goes faster the second time (?) |
yes, it will go faster the following times |
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
I think you need to build in order to generate the file |
…ibc-demo into cal/dummy-zk-programs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this through! There are FLUPs for:
but please create new issues if there are other FLUPs
make setup | ||
``` | ||
|
||
1. Make sure to set `SP1_PROVER=network` in `.env` and get sp1 prover network private key from celestia 1Password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does setting the SP1_PROVER=network
in local .env
actually impact the celestia prover running in Docker?
Overview
Partially fixes - #40