create evm prover #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxcanfly
force-pushed
the
tux/evm-prover
branch
from
1855d49 to
1fe17e8
Compare
Closed
tuxcanfly
force-pushed
the
tux/evm-prover
branch
from
1fe17e8 to
cef1c84
Compare
rootulp
reviewed
Jan 4, 2025
|
|
||
| impl ProverService { | ||
| async fn new() -> Result<Self, Box<dyn std::error::Error>> { | ||
| let token = env::var("CELESTIA_NODE_AUTH_TOKEN").expect("Token not provided"); |
There was a problem hiding this comment.
nit: this ENV variable isn't described in the README yet
| .await | ||
| .expect("Failed creating Celestia RPC client"); | ||
|
|
||
| let evm_rpc = env::var("EVM_RPC_URL").expect("EVM_RPC_URL not provided"); |
There was a problem hiding this comment.
nit: this ENV variable isn't described in the README yet
| cargo run | ||
| ``` | ||
|
|
||
| To use the SP1 Prover Network you should also populate the `SP1_PROVER` and `SP1_PRIVATE_KEY` environment variables. You can also use a `.env` file for all environment variables |
There was a problem hiding this comment.
question: should we provide an example.env that users can copy with pre-populated defaults for the environment variables?
Comment on lines
+83
to
+159
| // Use the namespace from the request or a default | ||
| let namespace = Namespace::new_v0(&alloy::hex::decode("0f0f0f0f0f0f0f0f0f0f").unwrap()) |
There was a problem hiding this comment.
nit: this doesn't use the namespace from the request yet, right?
Suggested change
| // Use the namespace from the request or a default | |
| let namespace = Namespace::new_v0(&alloy::hex::decode("0f0f0f0f0f0f0f0f0f0f").unwrap()) | |
| // Use a default namespace | |
| // TODO: use the namespace from the request | |
| let namespace = Namespace::new_v0(&alloy::hex::decode("0f0f0f0f0f0f0f0f0f0f").unwrap()) |
Comment on lines
+12
to
+14
| - `TENDERMINT_RPC_URL` - the url of the tendermint chain you are proving. | ||
| - `RPC_URL` the json rpc url of the evm chain you are generating the proofs for. | ||
| - `CONTRACT_ADDRESS` - the evm address of the tendermint sp1 ics07 contract. |
There was a problem hiding this comment.
nit: I think these environment variables don't reflect the environment variables expected by the EVM prover
tuxcanfly
force-pushed
the
tux/evm-prover
branch
from
cef1c84 to
75c317b
Compare
tuxcanfly
force-pushed
the
tux/evm-prover
branch
from
e7cf02b to
0f60e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[WIP] create evm proving service