feat: remove block data pruning restriction #681
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
evan-forbes
changed the title
evan-forbes
requested review from
sysrex,
rootulp,
cmwaters and
rach-id
and removed request for
a team
|
linting ci etc is failing, but nothing important or related to this PR trying to fix in #682 |
rootulp
reviewed
Sep 23, 2025
baseapp/abci.go
Outdated
Comment on lines
1359
to
1362
| // Default is 0 | ||
| var retentionHeight int64 | ||
|
|
||
| // Define the number of blocks needed to protect against misbehaving validators | ||
| // which allows light clients to operate safely. Note, we piggy back of the | ||
| // evidence parameters instead of computing an estimated number of blocks based | ||
| // on the unbonding period and block commitment time as the two should be | ||
| // equivalent. | ||
| cp := app.GetConsensusParams(app.finalizeBlockState.Context()) | ||
| if cp.Evidence != nil && cp.Evidence.MaxAgeNumBlocks > 0 { | ||
| retentionHeight = commitHeight - cp.Evidence.MaxAgeNumBlocks | ||
| } | ||
| retentionHeight = commitHeight - 1500 |
There was a problem hiding this comment.
Sorry I'm very confused. How is the default 0 if retentionHeight is commitHeight - 1500?
Also why not refactor this to just
retentionHeight := commitHeight - 1500Update: I found some historical context: #448 (comment)
I'm in favor of:
- Extracting a const that explains the 1500 magic number
- Increasing the number to something larger than the snapshot interval because I don't trust that this will help node operators block sync after a state sync given I expect a state sync'ed node to be more than 1500 blocks behind.
- Removing the "Default is 0" comment b/c that doesn't make sense to me
Co-authored-by: Rootul P <[email protected]>
|
@evan-forbes your pull request is missing a changelog! |
…lestiaorg/cosmos-sdk into evan/main/remove-storage-restrictions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening #448 on my own branch