Skip to content

Conversation

Copy link

Copilot AI commented Oct 21, 2025

  • Explore repository structure and locate README.md files
  • Verify that TxResponse struct includes the signers field
  • Check proto definition showing signers field at line 51 in abci.proto
  • Confirm signers field exists in generated Go code (types/abci.pb.go line 69)
  • Update main README.md to document the extended TxResponse with signers field
  • Test the changes to ensure no build failures
  • Verify TxResponse.Signers field works correctly with manual test
  • Move TxResponse documentation entry to bottom of the list per feedback
  • Final verification and documentation review

Changes made:

  • Added bullet point in README.md: "Extended TxResponse to include signers field with the list of transaction signers"
  • Moved the entry to the bottom of the fork changes list as requested
  • Verified the extension is working correctly through direct testing

Technical verification:

  • TxResponse struct properly includes Signers []string field
  • Field is defined in proto as repeated string signers = 14;
  • All builds and tests pass without issues
  • Manual verification confirms the field works as expected
Original prompt

This section details on the original issue you should resolve

<issue_title>Update the README to include extended signers field in TxResponse </issue_title>
<issue_description>1. We can prob add to the README that TxResponse was extended to include signers

Originally posted by @rootulp in #683 (review)
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #692


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Update README to include extended signers field in TxResponse docs: update README to document TxResponse signers field extension Oct 21, 2025
Copilot AI requested a review from rootulp October 21, 2025 14:09
Copilot finished work on behalf of rootulp October 21, 2025 14:09
Copilot AI requested a review from rootulp October 21, 2025 14:21
Copilot finished work on behalf of rootulp October 21, 2025 14:21
@rootulp rootulp marked this pull request as ready for review October 21, 2025 14:40
@rootulp rootulp requested a review from a team as a code owner October 21, 2025 14:40
@rootulp rootulp requested review from evan-forbes and tzdybal and removed request for a team October 21, 2025 14:40
@rootulp rootulp merged commit 3600803 into release/v0.51.x-celestia Oct 21, 2025
46 of 77 checks passed
@rootulp rootulp deleted the copilot/update-readme-signers-field branch October 21, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the README to include extended signers field in TxResponse

2 participants