A simple long running test #598
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| package longrunning | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/celestiaorg/knuu/pkg/instance" | ||
| "github.com/celestiaorg/knuu/pkg/knuu" | ||
| ) | ||
|
|
||
| const ( | ||
| alpineImage = "alpine:3.20.3" | ||
| testTimeout = time.Minute * 15 | ||
| ) | ||
|
|
||
| func TestSimple(t *testing.T) { | ||
|
There was a problem hiding this comment. Can we add a test where we test to change something (for example, the image) of an already running instance There was a problem hiding this comment. yes will add it There was a problem hiding this comment. yes it is added now. There was an issue with pvc applying and that one is also resolved in the recent commit |
||
| const ( | ||
| instanceName = "simple-id" | ||
| fileContent = "identifier:12345" | ||
| ) | ||
|
|
||
| ctx := context.Background() | ||
|
|
||
| ins1, err := createInstance(ctx, instanceName, "") | ||
| require.NoError(t, err) | ||
| testScope := ins1.Scope | ||
|
|
||
| t.Logf("Scope: %s", testScope) | ||
|
|
||
| _, err = ins1.Execution().ExecuteCommand(ctx, "echo", fileContent, ">", "/tmp/test-id") | ||
| require.NoError(t, err) | ||
|
|
||
| time.Sleep(1 * time.Second) | ||
mojtaba-esk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ins2, err := createInstance(ctx, instanceName, testScope) | ||
| require.NoError(t, err) | ||
|
|
||
| out, err := ins2.Execution().ExecuteCommand(ctx, "cat", "/tmp/test-id") | ||
| require.NoError(t, err) | ||
| require.Contains(t, out, fileContent) | ||
| } | ||
|
|
||
| func createInstance(ctx context.Context, name, testScope string) (*instance.Instance, error) { | ||
| knOpts := knuu.Options{Timeout: testTimeout} | ||
| if testScope != "" { | ||
| knOpts.Scope = testScope | ||
| } | ||
|
|
||
| kn, err := knuu.New(ctx, knOpts) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| kn.HandleStopSignal(ctx) | ||
|
|
||
| ins, err := kn.NewInstance(name) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Build().SetImage(ctx, alpineImage); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Build().Commit(ctx); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Build().SetStartCommand("sleep", "infinity"); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Execution().Start(ctx); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return ins, nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking for this PR, but I'm curious.
How would it look if I wanted to delete an instance from a long-running test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genius question, I will think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe user can just use the
Destroy()method and it should work.