Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CI for validating genesis and PR users #354

Merged
merged 4 commits into from
Oct 21, 2023
Merged

feat: add CI for validating genesis and PR users #354

merged 4 commits into from
Oct 21, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 13, 2023

Overview

Example of valid user: #356
Example of invalid user: #355

  • Test with genesis file
  • Add additional genesis file checks specific to mainnet.

feat(ci): initialize validation of validator PR user
@MSevey MSevey marked this pull request as ready for review October 19, 2023 15:10
@MSevey MSevey enabled auto-merge October 19, 2023 15:10
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@MSevey MSevey added this pull request to the merge queue Oct 21, 2023
Merged via the queue into master with commit c695aed Oct 21, 2023
9 checks passed
@MSevey MSevey deleted the sevey/ci branch October 21, 2023 09:17
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: 'User has previously submitted a gentx PR'
Copy link
Member

@liamsi liamsi Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems sth off with this. I think we are hitting

fmt.Println("Fail: User exists with different PR number")
return fmt.Errorf("User %s already exists with PR number %s", user, record[1])

in https://github.com/celestiaorg/networks/actions/runs/6597322356/job/17924245542?pr=362

But it's hard to say as we don't see any output from that tool.

but it's the only gentx they submitted 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants