Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arabica-11 #531

Merged
merged 2 commits into from
Jan 3, 2024
Merged

feat: add arabica-11 #531

merged 2 commits into from
Jan 3, 2024

Conversation

smuu
Copy link
Member

@smuu smuu commented Jan 2, 2024

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@smuu smuu requested review from tty47 and jcstein January 2, 2024 14:01
@smuu smuu self-assigned this Jan 2, 2024
tty47
tty47 previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🪨

jcstein
jcstein suggested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have seeds to use in addition to peers?

@smuu
Copy link
Member Author

smuu commented Jan 2, 2024

do we have seeds to use in addition to peers?

Until now, there was no need for seeds in arabica. So, no, there are no seed nodes.

@smuu smuu enabled auto-merge (squash) January 3, 2024 09:09
sysrex
sysrex approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@sysrex sysrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smuu smuu merged commit 6ab7657 into master Jan 3, 2024
7 of 8 checks passed
@smuu smuu deleted the smuu/add-arabica-11-cluster branch January 3, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcstein jcstein jcstein approved these changes

@tty47 tty47 tty47 approved these changes

@sysrex sysrex sysrex approved these changes

Assignees

@smuu smuu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smuu @sysrex @tty47 @jcstein