Baklava migration config #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
force-pushed
the
palango/baklava
branch
3 times, most recently
from
468064f to
75916ec
Compare
karlb
reviewed
Nov 25, 2024
Comment on lines
+83
to
+86
| BaklavaNetworkID: { | ||
| // DeterministicDeploymentProxy | ||
| common.HexToAddress("0x4e59b44847b379578588920cA78FbF26c0B4956C"): false, | ||
| }, |
There was a problem hiding this comment.
Why do we need only a single entry compared to the many for alfajores?
Author
There was a problem hiding this comment.
Processing address: 0xcA11bde05977b3631167028862bE2a173976CA11
Code mismatch for address: 0xcA11bde05977b3631167028862bE2a173976CA11
Codesize on https://baklava-forno.celo-testnet.org: 0
Nonce on https://baklava-forno.celo-testnet.org: 0
From the output we see that 0xcA11bde05977b3631167028862bE2a173976CA11 doesn't have any code or nonce on Baklava, so that account will be overwritten by default.
The same is true for all accounts besides the one listed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## celo10 #272 +/- ##
=======================================
Coverage 68.30% 68.31%
=======================================
Files 54 54
Lines 4118 4119 +1
=======================================
+ Hits 2813 2814 +1
Misses 1126 1126
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
palango
force-pushed
the
palango/baklava
branch
from
75916ec to
0fe03a5
Compare
Author
|
I'm not sure if the failure in |
palango
commented
Nov 26, 2024
palango
force-pushed
the
palango/baklava
branch
from
b5af4e8 to
4eba36c
Compare
Author
|
Updated to use the latest Baklava compatible op-geth. |
palango
force-pushed
the
palango/baklava
branch
from
4eba36c to
a00348e
Compare
This was referenced Nov 29, 2024
Closed
karlb
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration config was obtained form a little script checking all accounts. All but one of the contracts which exist on Alfajores are not deployed on Baklava.
Resolves https://github.com/celo-org/celo-blockchain-planning/issues/630