Skip to content

Add CLI config validation of op-batcher to prevent submitting Blobs into Alt DA #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kourin1996 merged 2 commits into from
Nov 29, 2024
Merged

Add CLI config validation of op-batcher to prevent submitting Blobs into Alt DA #274

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e63572
Add CLI config validation of op-batcher to prevent submitting Blobs t…
Kourin1996 Nov 27, 2024
6cbfedf
Add CLI config validation of op-batcher to prevent 'auto' data type a…
Kourin1996 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions op-batcher/batcher/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,9 @@ func (bs *BatcherService) initChannelConfig(cfg *CLIConfig) error {
return fmt.Errorf("unknown data availability type: %v", cfg.DataAvailabilityType)
}

if bs.UseAltDA && cfg.DataAvailabilityType == flags.BlobsType {
return fmt.Errorf("cannot use Blobs with Alt DA")
}
if bs.UseAltDA && cc.MaxFrameSize > altda.MaxInputSize {
return fmt.Errorf("max frame size %d exceeds altDA max input size %d", cc.MaxFrameSize, altda.MaxInputSize)
}
Expand Down
Loading