Resolve fuzzing test failures for AddressSortedLinkedListWithMedian #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as targets in fuzzing test of SafeCall_Test
karlb
approved these changes
Dec 9, 2024
karlb
left a comment
karlb
left a comment
There was a problem hiding this comment.
I'm not really sure what the SafeCall test actually tests, but skipping this contract is certainly better than having a flaky CI.
I was also told that "AddressSortedLinkedListWithMedian is one of the most stables pieces of code we have, so if we haven’t hit that case in any testnet and mainnet in 5 years, I’d say chances are the test is wrong", so I won't question why the test fails for that contract too much.
karlb
pushed a commit
that referenced
this pull request
Jan 13, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Jan 20, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Jan 27, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Jan 29, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Jan 29, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Jan 31, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Feb 4, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Feb 4, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
karlb
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
piersy
pushed a commit
that referenced
this pull request
May 7, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
piersy
pushed a commit
that referenced
this pull request
May 8, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
piersy
pushed a commit
that referenced
this pull request
May 8, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
piersy
pushed a commit
that referenced
this pull request
May 8, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
piersy
pushed a commit
that referenced
this pull request
May 20, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
piersy
pushed a commit
that referenced
this pull request
May 22, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 23, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 25, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 26, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 26, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 27, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 27, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 28, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Jul 28, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Aug 4, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Aug 6, 2025
…ListWithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Aug 7, 2025
…ithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Aug 8, 2025
…ithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Kourin1996
added a commit
that referenced
this pull request
Aug 11, 2025
…ithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
gastonponti
pushed a commit
that referenced
this pull request
Sep 22, 2025
…ithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
gastonponti
pushed a commit
that referenced
this pull request
Sep 22, 2025
…ithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
gastonponti
pushed a commit
that referenced
this pull request
Sep 23, 2025
…ithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
gastonponti
pushed a commit
that referenced
this pull request
Jan 8, 2026
…ithMedian (#277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
This PR adds skipping of fuzzing test in
test/libraries/SafeCall.t.solforAddressSortedLinkedListandAddressSortedLinkedListWithMedian.Fuzzing test in
test/libraries/SafeCall.t.sol, which calls random address with random method ID, callsAddressSortedLinkedListorAddressSortedLinkedListWithMedianwith high probability. The reason is because they are deployed before tests and their addresses are used as a input. Only library contracts having methods withpublicorexternalvisibilities might be target.This fuzzing test is just random call test and don't check functionality of these libraries. Then this PR skips testing for them.