DO NOT MERGE - v1.9.3 vs celo10 #287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary jobs
Setting `open-pull-requests-limit: 0` prevent version updates but should keep the security scans and updates according to https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates#overriding-the-default-behavior-with-a-configuration-file > If you only require security updates and want to exclude version > updates, you can set open-pull-requests-limit to 0 in order to prevent > version updates for a given package-ecosystem.
* adding trivy scanning to the Docker files * adding docker build scan * fixing typo * adding context for bedrock images * adding context to ops dockerfile packages * fixing context for ops packges: * removing push/pull triggers and adding just a manual workflow run with workflow_dispatch
As far as I understand, all gas values are for the L1 transaction that submits the tx batches. Therefore, the fee currency can be set to `nil`.
* Add pages workflow and forkdiff config * Remove TODOs * Update trigger to reflect future celo default branch pattern * Update latest rebased commit
Remove common/interfaces/IExchange.sol (duplicate) We keep the one in the `mento` directory. Remove common/libraries/ReentrancyGuard.sol (duplicate) Directly use the original from OpenZeppelin.
This allows testing of newly deployed fee currencies even when MockSortedOracles is used. This is the some implementation used in celo-monorepo (except for updating it to a more recent solidity version).
so that BridgedETH and other bridged ERC20 tokens can be used as fee currencies. I won't included testing until the FeeCurrencyDirectory is ready.
to avoid using old 0.5 solidity versions.
Until we fix the errors caused by enabling it.
We need to include Celo's contracts in the count to make it succeed.
…254) * OptimismPortal2 set initial `_balance` through StorageSetter pattern Fixes #239 The custom gas-token feature adaptation for the fault-proof system using the `OptimismPortal2` contract has been merged recently upstream. We are using the custom-gas-token feature and additionally require a modification of the OptimismPortal's `_balance` value to be set to the entire allocation of Celo on the L2 - meaning that all L1 token is initially locked in the bridge and only usable on the L2. Those changes are now adapted also to the `OptimismPortal2`, which was a requirement to make our custom-gas-token pre-locked balance feature work in conjunction with fault-proofs. * Adapt withdraw e2e-tests to work with fault-proofs * Use prettier for formatting e2e tests * Fix typo Co-authored-by: Valentin Rodygin <[email protected]> * Set L1-fee scalars to zero in devnet --------- Co-authored-by: Valentin Rodygin <[email protected]>
This allows us to reenable TestFees.
The test works now without further changes.
The tests now work without further changes.
This change deletes bad blocks at migration time, since we don't need to keep historical bad blocks and if not transformed like the other migrated blocks can lead to panics when trying to load them (which happens when a new bad block is discovered). I've tested this locally, by taking a datdir where bad blocks could be retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated it and verified that then the bad blocks cannot be retrieved which looks like this: INFO [10-28|13:00:32.736] Get operation failed error="leveldb: not found" Since the key is not present.
Build op-challenger and op-dispute-mon on CI
Using the branch name form our repo is easier to read and ensures that the corresponding commit hash is available, not matter what upstream does.
This is nice for testing the action without having to merge a PR.
…ype data into Alt DA
…nd Alt DA mode from being set at same time
…alidation Add CLI config validation of op-batcher to prevent submitting Blobs into Alt DA
Forge started to require the `--broadcast` flag for actually deploying a contract. Otherwise it will only do a dry-run. We should really pin our foundry version. But let's wait until we rebase to the latest upstream, since there have been changes to the overall setup. Closes #278
…277) * Ignore AddressSortedLinkedList and AddressSortedLinkedListWithMedian as targets in fuzzing test of SafeCall_Test * Format test/libraries/SafeCall.t.sol
Update the go package dependency and the devnet docker container reference of the `l2` service to the latest commit (`e6499495c176f568f72659293e29381a5c350a6b`) in the `celo10` ref. Co-authored-by: ezdac <[email protected]>
* Add script to update `celo-org/op-geth` dependencies Signed-off-by: Maximilian Langenfeld <[email protected]> * Add github action for update-geth script Signed-off-by: Maximilian Langenfeld <[email protected]> * Use inline geth base-ref Signed-off-by: Maximilian Langenfeld <[email protected]> * Discard automatic fields Signed-off-by: Maximilian Langenfeld <[email protected]> * token perms Signed-off-by: Maximilian Langenfeld <[email protected]> * Use read-only GCP SA Signed-off-by: Maximilian Langenfeld <[email protected]> * Better parameter handling in update-geth action Signed-off-by: Maximilian Langenfeld <[email protected]> * Remove `update-celo-geth` cmd from justfile --------- Signed-off-by: Maximilian Langenfeld <[email protected]> Co-authored-by: alvarof2 <[email protected]>
* addresses audit comments * fix errors * addresses feedback * missed defer statements
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This uses the default fee-currency-directory address from op-geth. It will fix the issue that the EVM calls into the directoy will fail when executed on the local devnet.
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
piersy
pushed a commit
that referenced
this pull request
Apr 8, 2025
* feat: interop fixes (#287) * feat: interop fixes * fix: natspec format * chore: add field on struct natspec --------- Co-authored-by: 0xDiscotech <[email protected]> * fix: campaign fixes (#313) * feat: interop fixes * fix: permit2 not inifinite approval check * chore: enhance superchain erc20 natspec * chore: tests natspec * fix: incorrect merge --------- Co-authored-by: agusduha <[email protected]> * chore: remove interop contracts (#318) * chore: remove unnecessary interop contracts * fix: golang tests * chore: remove system config interop and run pre pr * fix: exlude correct contracts on test to succeed * chore: update initializer array length * fix: semver lock * fix: L2 audit findings (#323) * fix: audit findings * chore: pre-pr * refactor: avoid stack too deep removing params on test (#324) --------- Co-authored-by: AgusDuha <[email protected]> Co-authored-by: agusduha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.