Update release branch #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was not substituting the go.mod file and the Dockerfile since the regexes were not matching. The regex for the Dockerfile contained '@sha256:' which perl was interpreting as a global symbol, in order to interpret it literally we needed to escape the '@'. The regex for the go.mod file contained an extra space before the arrow 'go-ethereum .* => ', in a tidied go.mod file there is one space between the package name and the arrow '=>'. Also adds failure output so that it's easier to debug where this is going wrong. --------- Co-authored-by: Karl Bartel <[email protected]> Co-authored-by: Paul Lange <[email protected]>
palango
reviewed
Feb 5, 2025
The substitution \1 and the beginning of the image hash together created
\150 which perl interprets as the octal character code for h.
To prevent this we need to use the \${1} notation to reference captured
groups.
piersy
force-pushed
the
piersy/update-release-branch
branch
from
4444de3 to
de5edc2
Compare
|
Still some errors: |
piersy
force-pushed
the
piersy/update-release-branch
branch
from
de5edc2 to
ffba5ac
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
palango
reviewed
Feb 5, 2025
piersy
force-pushed
the
piersy/update-release-branch
branch
from
e945c41 to
d28f4f0
Compare
palango
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the release branch with these fixes and the latest version of geth from the corresponding release branch (celo-release-v2.0) in op-geth.