Check DB Script fix, open DB without readonly flag #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecps
changed the title
piersy
reviewed
Feb 12, 2025
| return fmt.Errorf("failed to close db in readwrite mode: %w", err) | ||
| } | ||
|
|
||
| ancientDB, err := NewChainFreezer(filepath.Join(opts.dbPath, "ancient"), "", true) |
There was a problem hiding this comment.
With this change can we change how we open the db for the pre and full migrations, which are currently not using readonly.
Author
There was a problem hiding this comment.
In theory, but if we ever run those scripts without the continuity script before them for whatever reason they'll have this problem. It would be creating a hard dependency between the scripts. What do you think about that tradeoff?
There was a problem hiding this comment.
Oh I was thinking the open/close step came before all flows. Not a big issue.
piersy
requested changes
Feb 12, 2025
piersy
left a comment
piersy
left a comment
There was a problem hiding this comment.
This should be rebased onto, the celo-rebase-12 branch before being merged
alecps
force-pushed
the
alecps/fixCheckDBReadonly
branch
from
4075779 to
1a17d82
Compare
alecps
force-pushed
the
alecps/fixCheckDBReadonly
branch
from
1a17d82 to
5985c1a
Compare
piersy
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimism codebase expects there to be a certain type of file suffixed by
.metain the db that does not exist in our legacy dbs from cel1. These files are automatically created when we open the db in read/write mode using the optimism codebase, but not when we open in readonly mode. So, we need to add this change or else the script will fail when run on a legacy celo db for the first time.I didn't detect this earlier because the datadirs I've been testing the continuity script with locally already had the
.metafiles createdThis came up in testing for celo-org/celo-l2-node-docker-compose#32