forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 9
Add Prometheus metrics for AltDA failover in Batcher #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b979c0a
Add Prometheus metrics for AltDA failover in Batcher
Kourin1996 2e19f52
Fix calls of RecordBatchDaType
Kourin1996 13a163b
Revert deleted comment
Kourin1996 e645698
Add metrics for total stored batch size
Kourin1996 322252c
Fix condition for RecordBatchDaType and RecordBatchDataSizeBytes
Kourin1996 0ac389b
Add missing namespace to prometheus definition
Kourin1996 8f48a90
Fix the amount of batch sizes recorded for DA
Kourin1996 864aa5a
Unify recordings of size of batch to be stored
Kourin1996 137a44a
Improve Prometheus help text
Kourin1996 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
publishToAltDAAndL1()spawns a goroutine that in turn calls thesendTx, but only if the AltDA input can be set correctly.If you call this here, you get a "confirmation" for sending the tx, even though you could have aborted before the send and recorded a "failedDARequest".
I think I would only add one
Metr.RecordBatchDaTypecall in general and rather do that at the end of thesendTx(), but only if the passed inisCancel==falseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezdac You're right. For Alt DA, it recorded regardless of success or failure. Then I updated codes and now it records when
handleReceiptis called.