Skip to content

Conversation

@palango
Copy link

@palango palango commented May 14, 2025

Copy link

@piersy piersy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, out of interest do you know how the bootnodes for other networks are handled by the discovery system?

@palango
Copy link
Author

palango commented May 14, 2025

Looks good to me, out of interest do you know how the bootnodes for other networks are handled by the discovery system?

I'm not sure. I assume that the handshake would be rejected, but I'll have a look.

@seolaoh
Copy link

seolaoh commented May 14, 2025

Looks good to me, out of interest do you know how the bootnodes for other networks are handled by the discovery system?

IIRC, when decoding the ENR, there is a chain-specific field called opstack which is used to filter out bootnodes from other networks. (code)

@palango palango merged commit f448c9e into celo-rebase-12 May 14, 2025
32 checks passed
@palango palango deleted the palango/bootnodes branch May 14, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants