-
Notifications
You must be signed in to change notification settings - Fork 9
isthmus: Add hardfork timestamps #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fbf19fe to
593a08a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds Celo-specific hardfork activation overrides to the rollup configuration and bumps the op-geth replace version.
- Imported
paramsand calledapplyCeloHardforksinNewRollupConfigFromCLI - Implemented
applyCeloHardforksto set HF timestamps for Celo networks - Updated
go.modto point the go-ethereum replace directive at a newerop-gethversion
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| op-node/service.go | Added applyCeloHardforks function and invocation |
| go.mod | Updated replace directive for github.com/ethereum/go-ethereum |
Comments suppressed due to low confidence (2)
op-node/service.go:293
- [nitpick] The function name
applyCeloHardforksis a bit generic; consider renaming it to something likeapplyCeloHardforkActivationTimesto clarify its purpose.
func applyCeloHardforks(rollupConfig *rollup.Config) {
op-node/service.go:290
- New logic in
applyCeloHardforkslacks test coverage; adding unit tests for each supported Celo chain ID would help catch regressions.
// applyCeloHardforks modifies the rollupConfig to apply Celo-specific hardforks.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
29340ee to
f121ad4
Compare
f121ad4 to
8ada5c3
Compare
|
@gastonponti Updated this with latest op-geth. |
HF activation overrides for celo networks
(Workaround until having the config in the superchain)
Depends on celo-org/op-geth#388
Depends on celo-org/op-geth#390
Closes https://github.com/celo-org/celo-blockchain-planning/issues/795
Closes https://github.com/celo-org/celo-blockchain-planning/issues/936