Skip to content

Conversation

@gastonponti
Copy link

@gastonponti gastonponti commented May 28, 2025

HF activation overrides for celo networks
(Workaround until having the config in the superchain)

Depends on celo-org/op-geth#388
Depends on celo-org/op-geth#390

Closes https://github.com/celo-org/celo-blockchain-planning/issues/795
Closes https://github.com/celo-org/celo-blockchain-planning/issues/936

@palango palango force-pushed the palango/simpler-config branch from fbf19fe to 593a08a Compare May 28, 2025 12:03
@palango palango requested a review from Copilot May 28, 2025 12:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Celo-specific hardfork activation overrides to the rollup configuration and bumps the op-geth replace version.

  • Imported params and called applyCeloHardforks in NewRollupConfigFromCLI
  • Implemented applyCeloHardforks to set HF timestamps for Celo networks
  • Updated go.mod to point the go-ethereum replace directive at a newer op-geth version

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
op-node/service.go Added applyCeloHardforks function and invocation
go.mod Updated replace directive for github.com/ethereum/go-ethereum
Comments suppressed due to low confidence (2)

op-node/service.go:293

  • [nitpick] The function name applyCeloHardforks is a bit generic; consider renaming it to something like applyCeloHardforkActivationTimes to clarify its purpose.
func applyCeloHardforks(rollupConfig *rollup.Config) {

op-node/service.go:290

  • New logic in applyCeloHardforks lacks test coverage; adding unit tests for each supported Celo chain ID would help catch regressions.
// applyCeloHardforks modifies the rollupConfig to apply Celo-specific hardforks.

@socket-security
Copy link

socket-security bot commented May 28, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@palango palango changed the title Simpler HF activation celo override isthmus: Add hardfork timestamps May 28, 2025
@palango palango force-pushed the palango/simpler-config branch from 29340ee to f121ad4 Compare May 28, 2025 13:23
@palango palango force-pushed the palango/simpler-config branch from f121ad4 to 8ada5c3 Compare June 4, 2025 09:43
@palango
Copy link

palango commented Jun 4, 2025

@gastonponti Updated this with latest op-geth.

@palango palango merged commit db6e149 into celo-rebase-13 Jun 4, 2025
31 of 32 checks passed
@palango palango deleted the palango/simpler-config branch June 4, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants