-
Notifications
You must be signed in to change notification settings - Fork 9
github: Detect OP_GETH_BASE_BRANCH in update-geth workflow #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Minor additional changes: * use a more informative job id than "job_id" * add quotes to silence shellcheck warnings Closes celo-org/celo-blockchain-planning#933
89c0a98 to
ed17476
Compare
The previous command yielded multiple results: ``` > git ls-remote https://github.com/celo-org/op-geth/ "celo-rebase-14" 18fdf55a858a46e5838c72f0e1eddcae00ced616 refs/heads/Kourin1996/celo-rebase-14 df2ea968968d4910ce21b44280a0077a54f73d3f refs/heads/celo-rebase-14 ``` That led to a malformed GITHUB_OUTPUT and caused job errors like ``` Error: Unable to process file command 'output' successfully. Error: Invalid format 'df2ea968968d4910ce21b44280a0077a54f73d3f' ```
2ea7fe0 to
1ecfb0f
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 11. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
Issue for CircleCI failure: #407 |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## celo-rebase-14 #405 +/- ##
==================================================
- Coverage 45.87% 5.26% -40.62%
==================================================
Files 1391 4 -1387
Lines 113072 76 -112996
==================================================
- Hits 51873 4 -51869
+ Misses 57502 70 -57432
+ Partials 3697 2 -3695
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
* github: Detect OP_GETH_BASE_BRANCH in update-geth workflow Minor additional changes: * use a more informative job id than "job_id" * add quotes to silence shellcheck warnings Closes https://github.com/celo-org/celo-blockchain-planning/issues/933 * github: Fix ambiguous ls-remote match The previous command yielded multiple results: ``` > git ls-remote https://github.com/celo-org/op-geth/ "celo-rebase-14" 18fdf55a858a46e5838c72f0e1eddcae00ced616 refs/heads/Kourin1996/celo-rebase-14 df2ea968968d4910ce21b44280a0077a54f73d3f refs/heads/celo-rebase-14 ``` That led to a malformed GITHUB_OUTPUT and caused job errors like ``` Error: Unable to process file command 'output' successfully. Error: Invalid format 'df2ea968968d4910ce21b44280a0077a54f73d3f' ```
Also fix the
Error: Unable to process file command 'output' successfully.problem that made this job fail since May 26.Minor additional changes:
Closes https://github.com/celo-org/celo-blockchain-planning/issues/933