Skip to content

Conversation

@karlb
Copy link

@karlb karlb commented Sep 23, 2025

Also fix the Error: Unable to process file command 'output' successfully. problem that made this job fail since May 26.

Minor additional changes:

  • use a more informative job id than "job_id"
  • add quotes to silence shellcheck warnings

Closes https://github.com/celo-org/celo-blockchain-planning/issues/933

Minor additional changes:
* use a more informative job id than "job_id"
* add quotes to silence shellcheck warnings

Closes celo-org/celo-blockchain-planning#933
@karlb karlb force-pushed the karlb/detect-base-branch branch from 89c0a98 to ed17476 Compare September 23, 2025 10:14
The previous command yielded multiple results:
```
> git ls-remote https://github.com/celo-org/op-geth/ "celo-rebase-14"
18fdf55a858a46e5838c72f0e1eddcae00ced616	refs/heads/Kourin1996/celo-rebase-14
df2ea968968d4910ce21b44280a0077a54f73d3f	refs/heads/celo-rebase-14
```

That led to a malformed GITHUB_OUTPUT and caused job errors like
```
Error: Unable to process file command 'output' successfully.
Error: Invalid format 'df2ea968968d4910ce21b44280a0077a54f73d3f'
```
@karlb karlb force-pushed the karlb/detect-base-branch branch from 2ea7fe0 to 1ecfb0f Compare September 23, 2025 11:39
@karlb karlb marked this pull request as ready for review September 23, 2025 11:53
@cursor
Copy link

cursor bot commented Sep 23, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 11.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@karlb
Copy link
Author

karlb commented Sep 23, 2025

Issue for CircleCI failure: #407

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 5.26%. Comparing base (6405229) to head (1ecfb0f).

❗ There is a different number of reports uploaded between BASE (6405229) and HEAD (1ecfb0f). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (6405229) HEAD (1ecfb0f)
contracts-bedrock-tests 3 0
2 1
Additional details and impacted files
@@                Coverage Diff                 @@
##           celo-rebase-14    #405       +/-   ##
==================================================
- Coverage           45.87%   5.26%   -40.62%     
==================================================
  Files                1391       4     -1387     
  Lines              113072      76   -112996     
==================================================
- Hits                51873       4    -51869     
+ Misses              57502      70    -57432     
+ Partials             3697       2     -3695     
Flag Coverage Δ
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1390 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@karlb karlb merged commit 368507f into celo-rebase-14 Oct 9, 2025
22 of 27 checks passed
@karlb karlb deleted the karlb/detect-base-branch branch October 9, 2025 04:27
gastonponti pushed a commit that referenced this pull request Jan 8, 2026
* github: Detect OP_GETH_BASE_BRANCH in update-geth workflow

Minor additional changes:
* use a more informative job id than "job_id"
* add quotes to silence shellcheck warnings

Closes https://github.com/celo-org/celo-blockchain-planning/issues/933

* github: Fix ambiguous ls-remote match

The previous command yielded multiple results:
```
> git ls-remote https://github.com/celo-org/op-geth/ "celo-rebase-14"
18fdf55a858a46e5838c72f0e1eddcae00ced616	refs/heads/Kourin1996/celo-rebase-14
df2ea968968d4910ce21b44280a0077a54f73d3f	refs/heads/celo-rebase-14
```

That led to a malformed GITHUB_OUTPUT and caused job errors like
```
Error: Unable to process file command 'output' successfully.
Error: Invalid format 'df2ea968968d4910ce21b44280a0077a54f73d3f'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants