Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

normalize behavior of Connectors around lastusedFeeCurrency #189

Open
aaronmgdr opened this issue May 17, 2022 · 0 comments
Open

normalize behavior of Connectors around lastusedFeeCurrency #189

aaronmgdr opened this issue May 17, 2022 · 0 comments
Assignees
@zhaonancy
Labels
Applications

Comments

@aaronmgdr
Copy link
Member

Some Connectors set lastUsedFeeCurrency in LocalStorage on construction, others dont

None of them update the value in localStorage when updateFeeCurrency is called

Should feeCurrency be saved to localStorage?

Probably not since if anything it should be settable per tx easily.

Also make it not a required arg in Connectors Constructor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zhaonancy zhaonancy

Labels
Applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize behavior of Connectors around lastusedFeeCurrency celo-org/react-celo
2 participants
@aaronmgdr @zhaonancy