This repository has been archived by the owner on Dec 11, 2024. It is now read-only.
Normalize behavior of Connectors around lastusedFeeCurrency #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zhaonancy
force-pushed
the
zhaonancy/remove-last-used-fee-currency
branch
from
937c333 to
8242e75
Compare
aaronmgdr
suggested changes
Jun 7, 2022
There was a problem hiding this comment.
This would be a breaking change and so should not be in 4.1.
We should discus how we want this to work in 5.0
I do agree that in the end it doesnt make sense to store it in local storage, or require it to be passed into Connector constructors.
either it becomes become solely an optional updator on connectors
or we remove external ability to update and internally for connector wallets that support it we find the best fee currency at tx time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189