Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] Stable installs #148

Open
jordy25519 opened this issue Aug 13, 2020 · 0 comments
Open

[Tracker] Stable installs #148

jordy25519 opened this issue Aug 13, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jordy25519
Copy link
Contributor

jordy25519 commented Aug 13, 2020

We depend on some @polkadot/* packages which we lock to specific versions for development purposes, all is fine.
However yarn.lock and package-lock.json are ignored in published packages, so user installs may break if a dependency of our dependencies doesn't respect semver.

This problem is common in many package ecosystems, normally the offending package should be yanked.
However @polkadot/* moves fast and breaks stuff so we can't rely on that here.

To provide stable installs, current known options are (in order of preference):

  • Strongly suggest users useyarn + resolutions in their package.json
  • Publish a shrinkwrap.json for npm (risks attached)
  • Hope @polkadot respects semver after doing some upgrade work
  • Vendor deps (pls no)
@jordy25519 jordy25519 added the enhancement New feature or request label Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant