Initial branch with api-types replaced in types #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaBothara
commented
Oct 15, 2020
KarishmaBothara
commented
Oct 15, 2020
* Fix rxapi.create.e2e and rxapi.queries.e2e
* Generate the new rpc structure * Remove resolution set for polkadot/keyring * Fix jest debugging issue by updating jest packages * Enable generic asset rpc test
* fix generate slim metadata
* Updated API to use derived queries
* Cleaned up commented code, fixed all the tests
KarishmaBothara
commented
Oct 21, 2020
* final clean up before release branch
KarishmaBothara
commented
Oct 22, 2020
| **/ | ||
| maxSignatories: u16 & AugmentedConst<ApiType>; | ||
| }; | ||
| // @ts-ignore // staking also exist in polkadot at ../node_modules/@polkadot/api/augment/consts.d.ts |
There was a problem hiding this comment.
This line was added in auto generated file
KarishmaBothara
commented
Oct 22, 2020
| **/ | ||
| validators: AugmentedQuery<ApiType, () => Observable<Vec<ValidatorId>>> & QueryableStorageEntry<ApiType>; | ||
| }; | ||
| // @ts-ignore // staking also exist in polkadot at ../node_modules/@polkadot/api/augment/query.d.ts:583:9 |
There was a problem hiding this comment.
This line was added in auto generated file
KarishmaBothara
commented
Oct 22, 2020
| RewardBalanceOf: RewardBalanceOf; | ||
| 'Option<RewardBalanceOf>': Option<RewardBalanceOf>; | ||
| 'Vec<RewardBalanceOf>': Vec<RewardBalanceOf>; | ||
| // @ts-ignore - As RewardDestination is also available in polkadot's type.. Subsequent property declarations must have the same type. Property 'RewardDestination' must be of type 'RewardDestination', but here has type 'RewardDestination'. |
There was a problem hiding this comment.
This line was added in auto generated file
aliXsed
approved these changes
Oct 22, 2020
jordy25519
approved these changes
Oct 22, 2020
|
|
||
| super(options as ApiOptionsBase); | ||
| } | ||
| } | ||
|
|
||
| async function withTimeout(promise: Promise<Api>, timeoutMs: number = DEFAULT_TIMEOUT): Promise<Api> { | ||
| async function withTimeout(promise: Promise<Api>, timeoutMs: number): Promise<Api> { |
There was a problem hiding this comment.
what is the new default timeout / behaviour here?
There was a problem hiding this comment.
@alexsednz ?
There was a problem hiding this comment.
The same as before. DEFAULT_TIMEOUT is moved to the same file where getTimeout is implemented. So instead of having DEFAULT_TIMEOUT in Api and then importing it in several places including ApiRx (which is considered a sibling to Api, meaning at the same level in the hierarchy) Now we call getTimeout and getTimeout will return the user-specified timeout or otherwise the default value.
This was referenced Oct 22, 2020
jordy25519
added a commit
that referenced
this pull request
May 10, 2021
* Reverted back fee changes (#53) * Reversed the fix fee tests #57 * Fix fee e2e test * Refine circleci config * Update dependency (#69) * Update dependency from plugnet to polkadot * Update extrinsic v2 (#70) * Added extrinsic v2 support (CENNZnet develop branch) * Ensure all tests in generic asset are ok to go with rc1 node (#73) * Set up private testnet with circleci integration test * Bump handlebars from 4.1.2 to 4.5.3 * Revert babel config to get build work * Update CENNZnet image version to 1.0.0-rc1 (#80) Update Index/nonce type to u64 Replace tip with ChargeTransactionPayment struct * Add release notes for 1.0.0-alpha * Add development guideline * Fee payment (#85) * Add support for multi-currency fee payment * Upgrade to polkadot v1.1.1 (#86) * Compatibility with CENNZnet 1.0.0-rc2 * Test for querying extrinsic fee * Update read me, dependency and some clean up * Support CENNZnet node's develop branch (#89) * Support CENNZnet node's develop branch * Added sha hash of latest CENNZnet develop branch image in docker-compose * Added code & test for rpc call to get price queries (#90) * Added code & test for rpc call to get price queries * Remove deprecated method from crml-cennzx-spot repo (#91) * Added derived query and test case to get estimated fee * as per review comments * as per review comment * as per review comment * wip to fix issue of adding construction in types * as per code review comment * Added some scenario for estimate fee interface * Get api.js work with latest cennznet (#94) * Fix cennznet docker image version (#96) * chore(deps): bump acorn from 5.7.3 to 5.7.4 (#92) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated sdk to work with latest image CENNZnet 1.0.0 (#98) * Updated sdk to work with latest image CENNZnet 1.0.0 * Release 1.0.0 (cennznet/cennznet:latest) (#95) * Added changes to enable the skipped test from API * wip * added console logs to check on docker, works on local * Added changes for both genesis hash * as per review comment * remove console logs * Updated static meta to use latest cennznet genesis hash * removed unused import * Fix generate docs (#100) * Fix generate docs * fix decoding of pkb response (#104) * Add Message and MessageId types for Sylo * Release 1.0.1 (cennznet/cennznet:1.0.0) Docker digest: sha256:c33d37c52a6b980ef7e93efbee7383a413616077ecfee9b7e9585d8f834793cd * add null constructor to sylo runtime response enum (#109) * Release 1.0.2 (cennznet/cennznet@sha256:c33d37c52a6b980ef7e93efbee7383a413616077ecfee9b7e9585d8f834793cd) (#110) * Updated static metadata (#112) * Updated static metadata * Updated/added test cases and a script to auto generate staticMetadata * chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 (#113) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Api compatible with node (#115) * Fixed few tests and added additional type for GA * updated docker image to using rc1 image * Updated github link of the branch docker image is pointing to * commented the github cennznet node branch link * Feat/support on chain asset registry (#116) * Changes to support on-chain asset-registry via SDK * Added support for liquidity RPC calls (#117) * Added support for liquidity RPC calls * Update and Fix examples and correct example names Some examples would be still failing but we will have separate tickets for them * Chore/generate slim data (#120) * script to generate slim meta data * Release 1.0.3 (cennznet/cennznet:1.1.0-rc1) (#118) * Update get_started doc * Add FAQ * Mention polkadot keyring instead of our own wallet. Also explain CENNZ, Alice and BOB consts. * Label the link * create not connect * A minor sentence correction * Updated azalea metadata (cherry picked from commit a82b211) * Updated slim metadata in a test case (cherry picked from commit 68aae9e) * Update README (#124) Move release notes to changelogs Correct author field * chore(deps): bump lodash from 4.17.15 to 4.17.19 (#125) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Tidy up tx.e2e.tests (#127) Add genericAsset.updateAssetInfo test * change -> chain * Doughnut extrinsic support (#126) * Add doughnut + CENNZnut e2e tests * Fix TS SignerOptions to include doughnut Co-authored-by: karishma <[email protected]> Co-authored-by: Jordan <[email protected]> * Add initialization to extrinsic phase (#130) * Release/1.1.0 (#136) * Release 1.1.0 (cennznet/cennznet:develop-993900) * chore(deps): bump elliptic from 6.5.2 to 6.5.3 (#137) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add @plugnet/doughnut-wasm to deps (#139) * It should be in types deps, not devDeps * Release 1.1.1 (cennznet/cennznet:develop-993900) (#140) * testing new mac * Made doughnut wasm packages as optional dependencies and used try/cat… (#142) * Made doughnut wasm packages as optional dependencies and added conditional compile support for doughnuts * Release 1.1.2 (cennznet/cennznet:develop-993900) (#144) * chore(deps): bump prismjs from 1.19.0 to 1.21.0 (#143) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.19.0 to 1.21.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.19.0...v1.21.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add derived query for staking accounts (#145) * Added customise staking query * Fix withdraw reasons decoding (#146) * no coupling between session and account info query for staking (#147) * no coupling between session and account info query for staking * Add staking e2e tests (#141) * Remove rewards type definitions * Add staking type definitions * Implement e2e test for user & governance staking methods * Support underscore in number with babel plugin (#152) * Support underscore in number with babel plugin Co-authored-by: Jordan Beauchamp <[email protected]> * Release 1.2.0 (cennznet/cennznet:develop-993900) (#151) * Fix API connection by moving types in a different file (#154) * Fix API connection issue by moving types in a different file * Release 1.2.1 (cennznet/cennznet:develop-993900) (#156) * Converted tslint file to eslint and extended eslintrc with recommended typescript-eslint, eslint recommended checks and recommended-requiring-type-checking rules (#159) * chore(deps): bump http-proxy from 1.18.0 to 1.18.1 (#169) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.18.0...1.18.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Replace wallet with polkadot/keyring (#171) * Replace wallet with polkadot/keyring * Specify the type: 'sr25519' for test keyrings * Restore the resolution for the example project * Support nodes develop branch (#172) * Support nodes develop branch * Updated prettierrc to use bracketSpacing as true to support a space after curly brace (#173) * Use @cennznet/types uniformly wherever possible (#177) * Use @cennznet/types uniformly wherever possible * updated test (#178) Co-authored-by: KarishmaBothara <[email protected]> * Add the publish CircleCi job for the release branches (#175) Add the publish CircleCi job for the release branches * Fix yarn lint command (#181) * Chore/consistency (#179) Made change to make the repo more consistent * Fixed forceUnbond test race condition (#182) * Make attestation derive only (#180) * Make attestation derive only, remove crml-generic-asset and crml-attestion packages * updated attestation rx test Co-authored-by: karishma <[email protected]> * Changes to move the cennzx derived queries to api derives and refine t… (#183) * Make cennzx derive only * Chore/update readme with resolutions (#184) * Update APIs readme as well as resolutions from example to include jsonrpc and rpc-provider * Updated readme in the doc examples * Initial branch with api-types replaced in types (#186) * Upgraded with latest polkadot version (^2.3.1) Co-authored-by: Alex Sed <[email protected]> * Maintain the behaviour of ApiRx connection establishment strictly as it used to be (#197) * updated docker compose (#199) * Fixed all tests as per latest develop branch commit (develop-e8f05b) * 1.3.0 alpha.1 (#200) * Updated package version and changelog * updated depencies * update versions (#201) * added login step in circle ci config (#202) * Updated package version and changelog (#204) Deprecated last version 1.3.0-alpha.1 and bump to version 1.3.0-alpha.2 * Updated API to support 1.2.0-rc1-node (#208) * Updated API to support 1.2.0-rc1-node * support decoding of old block and current block on V37 chain (#209) * support decoding of old block and current block on V37 chain * Fix sylo types (#211) * Fix sylo types * update node version (#213) * Updated documentation in this repo (#212) * Updated documentation in this repo * chore(deps-dev): bump semantic-release from 15.14.0 to 17.2.3 (#210) Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 15.14.0 to 17.2.3. - [Release notes](https://github.com/semantic-release/semantic-release/releases) - [Commits](semantic-release/semantic-release@v15.14.0...v17.2.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 1.3.0 (#215) * Release 1.3.0 Signed-off-by: KarishmaBothara <[email protected]> * RPC definitions at one place (#217) * chore(deps): bump highlight.js from 9.18.1 to 9.18.5 (#219) Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.18.1 to 9.18.5. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/9.18.5/CHANGES.md) - [Commits](highlightjs/highlight.js@9.18.1...9.18.5) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixed fee asset example while sending extrinsic (#220) * Fixed fee asset example while sending extrinsic * Generating types from API repo (#222) * Generate @cennznet/types from metadata * disconnect the finality node open in test * Fix event decoding with rv 36 (#223) * Fix event decoding with rv 36 * update dependencies (#233) * Update rxjs -> util Update all @PolkaDot dependencies Remove semantic-release/czchangelog as unused * generate and update types after rebase * subscribe for only next 3 events - to prevent test from timeout * dont patch phase for rv36 * as per review comment Co-authored-by: Jordan Beauchamp <[email protected]> * Add a minimal test suite for v36 backwards compatibility (#236) * Add a minimal test suite for v36 backwards compatibility Co-authored-by: KarishmaBothara <[email protected]> * Release/1.3.1 (#238) * Releasing the 1.3.1 version * as per review comment * publish release branch * [ci skip] undo ci changes Co-authored-by: Jordan Beauchamp <[email protected]> * Chore/gh actions (#218) * Use GH actions * Fix typescript errors 4.1.* * On push to develop also * Fix dependencies in API project (#239) * add ci badge to readme (#240) * Trying to fix issue - #241 (#242) * Making sure util is not used anywhere before releasing new version (#245) * Pre release branch for CENNZnet API to release 1.3.2 version. (#246) * Prerelease/1.3.2 (#247) * Prerelease/1.3.2 (#248) * Prerelease/1.3.2 (#250) * Added test for decode/encode response format and added doc example for rx subscribe pinned at version polkadot/rpc-provider 2.7.1 (#251) * Added test for decode/encode response format and added doc example for rx subscribe pinned at version polkadot/rpc-provider 2.7.1 * chore(deps): bump ini from 1.3.5 to 1.3.7 (#252) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * API compatible with latest develop branch (#259) * API compatible with latest develop branch Signed-off-by: KarishmaBothara <[email protected]> * address review comments * Pre release 1.3.3-alpha.1 (cennznet/cennznet:develop-4ff509) (#260) * Prerelease/1.3.3 alpha.1 (#261) * prerelease 1.3.3-alpha.1 signed commit (#262) * Prerelease version 1.3.3 (#263) * Prevent trigger for github publish pipeline unless automerge label is applied (#267) * chore(deps): bump prismjs from 1.22.0 to 1.23.0 (#265) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.22.0 to 1.23.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.22.0...v1.23.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump elliptic from 6.5.3 to 6.5.4 (#266) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added extrinsicPayload in registry (#258) * Added extrinsicPayload in registry and test case for signing extrinsic via signer * Pre release branch for CENNZnet API to release 1.3.4 version (#268) * Re-generated docs from latest metadata (#270) * Chore/update slim meta script (#271) * optimise slim data with asCallsOnly logic from MetadataVerisoned * clean up * Copied staking derived queries from UI project (#272) * Copied staking derived queries from UI project * chore(deps): bump y18n from 4.0.0 to 4.0.1 (#274) * chore(deps): bump y18n from 4.0.0 to 4.0.1 Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: KarishmaBothara <[email protected]> * Batch transfer example (#275) * explain in example how to use batch utility * Add NFT initial types/interfaces (#276) * Add type definitions for NFT module * restore grandpa extra rpc * augment our types * Remove unused staking derive query * Prep 1.3.5-alpha.0 release (#280) * Refactor v36 compatibility tests (#283) * Refactor v36 compatability tests * chore(deps): bump ssri from 6.0.1 to 6.0.2 (#282) Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update readme (#284) Remove unused scripts CENNZX trade e2e test isFinalized -> isInBlock Fix babel warning * Update NFT metadata (#285) * Update NFT metadata and add some e2e tests * Fix decimal places in registeredAssets test * Backport NFT meta/type updates from 2.0.0 * split 1.0 & 2.0 release pipeline * rename stable to master * stable -> master * Update release instructions in readme * update if guard in GH actions Co-authored-by: karishma <[email protected]> Co-authored-by: Ben Gao <[email protected]> Co-authored-by: alex zhen wang <[email protected]> Co-authored-by: Ben Gao <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JCSanPedro <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: AlexSedNZ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base branch with minimum functionality..
Many files are commented now and can be uncommented once we start working on that feature..
Once we all are happy, we can start working on small pieces
Fix RPC calls
Fix timeout option when incorrect provider URL is provided
Fix staking transactions
Fix derive queries
Check GA create working
Fix CENNZX
Fix RxJs API
Fix generate slim metadata for Sylo
closes #114 #129 #148 #149 #166 #157
probably closes #155