Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/historical withdrawal #121

Closed
wants to merge 13 commits into from
Closed

Feature/historical withdrawal #121

wants to merge 13 commits into from

Conversation

aidan-starke
Copy link
Contributor

@aidan-starke aidan-starke commented Mar 22, 2022 •
edited
Loading

Description

  • Allow user to claim historical withdrawals

Details

Changes

  • extract withdrawETHSide functionality for use in both Withdraw & Advanced
  • under Advanced on Bridge withdraw display UNclaimed tx's:

Screen Shot 2022-03-24 at 3 18 55 PM

Notes

  • withdrawals endpoint doesn't seem to have updated hasClaimed status when claim is made

@vercel
Copy link

vercel bot commented Mar 22, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cennznet/app-hub/5t5cWJx4KyxCF5bFBaK9Pvt2KQT1
✅ Preview: https://app-hub-git-feature-historical-withdrawal-cennznet.vercel.app

@vercel vercel bot temporarily deployed to Preview March 22, 2022 21:56 Inactive
@aidan-starke aidan-starke marked this pull request as ready for review March 22, 2022 21:58
@vercel vercel bot temporarily deployed to Preview March 22, 2022 22:17 Inactive
@aidan-starke aidan-starke marked this pull request as draft March 23, 2022 18:30
@vercel vercel bot temporarily deployed to Preview March 24, 2022 00:35 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2022 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2022 02:11 Inactive
@aidan-starke aidan-starke requested a review from eupston March 24, 2022 02:16
@vercel vercel bot temporarily deployed to Preview March 24, 2022 02:44 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2022 02:46 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2022 20:42 Inactive
@aidan-starke aidan-starke marked this pull request as ready for review March 24, 2022 20:47
@vercel vercel bot temporarily deployed to Preview March 24, 2022 23:24 Inactive
@aidan-starke aidan-starke marked this pull request as draft March 25, 2022 01:18
@ken-futureverse ken-futureverse added this to the v1.x milestone Mar 29, 2022
@ken-futureverse
Copy link
Collaborator

Update this to milestone 1.x FYI

@aidan-starke
Copy link
Contributor Author

updated version PR #140

@aidan-starke aidan-starke deleted the feature/historical-withdrawal branch April 19, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarishmaBothara KarishmaBothara Awaiting requested review from KarishmaBothara

@ken-futureverse ken-futureverse Awaiting requested review from ken-futureverse

@eupston eupston Awaiting requested review from eupston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@aidan-starke @ken-futureverse