enable on cennznet extension #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordy25519
approved these changes
Oct 14, 2021
KarishmaBothara
force-pushed
the
useOnlyCENNZnetExtension
branch
from
eea4ead to
db1cfac
Compare
jordy25519
reviewed
Oct 20, 2021
.eslintrc.js
Outdated
| @@ -12,7 +12,8 @@ module.exports = { | |||
| '.yarn/**', | |||
| '**/build/*', | |||
| '**/coverage/*', | |||
| '**/node_modules/*' | |||
| '**/node_modules/*', | |||
| '**/config.ts' | |||
There was a problem hiding this comment.
just checking which file were you planning to exclude?
packages/extension-chains/src/config.ts still included
There was a problem hiding this comment.
excluded it... had few listing err in it... mostly related to sort-key in types..
but in case of enum we don't really want to sort...hv added at the top of the file /* eslint sort-keys: 0 */
.github/workflows/publish.yml
Outdated
| run: | | ||
| echo "//registry.npmjs.org/:_authToken=${NPM_KEY}" > ~/.npmrc | ||
| echo 'Publishing to npmjs.org.' | ||
| npx lerna exec -- 'cd build && npm publish --access public' |
There was a problem hiding this comment.
can add --dry-run if you want to test the CI before publishing
Suggested change
| npx lerna exec -- 'cd build && npm publish --access public' | |
| npx lerna exec -- 'cd build && npm publish --access public' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.