-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Phase 1 #141
Refactor: Phase 1 #141
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cennznet/litho/FwB6PaG9DqNLMLHBhsMiXbA8s8Nc |
very nicely structured.. nice work |
@KarishmaBothara ready for round 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The main goal of this PR is to bring stability to the app which will serve as a foundation for any future enhancements
Improvements
Refine UI interface
Break the
Web3
provider component into smaller providers for code legibilityUtilise Dynamic Import in Next to load client only libraries, e.g
@polkadot/extension-dapp
Utilise Next Image Optimisation
Better support when switching between wallet accounts
Responsive styling for mobile and tablet read only mode
Closes
NFTDataWrapper
is constantly being re-rendered #134Closes False success message when Buy Now fails, in a listing that's directly selling to a different account #118 (Remove the buy now button if user is not designated buyer)
Closes Allow users to connect different accounts #93 (Simplified)
Closes Install modal appears behind marketplace #89
Closes Click to show large version of image #88
Closes Support new metadata standard #126
Closes Marketplace error #124
Closes Fix SEO results #94
Closes Featured listing api - Internal Server Error. #75
Closes Improve mint flow #11