Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Phase 1 #141

Merged
merged 234 commits into from
Mar 14, 2022
Merged

Refactor: Phase 1 #141

merged 234 commits into from
Mar 14, 2022

Conversation

ken-futureverse
Copy link
Collaborator

@ken-futureverse ken-futureverse commented Jan 18, 2022

The main goal of this PR is to bring stability to the app which will serve as a foundation for any future enhancements

Improvements

@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cennznet/litho/FwB6PaG9DqNLMLHBhsMiXbA8s8Nc
✅ Preview: https://litho.centrality.me

@vercel vercel bot temporarily deployed to Preview January 19, 2022 20:08 Inactive
@vercel vercel bot temporarily deployed to Preview January 20, 2022 07:02 Inactive
@vercel vercel bot temporarily deployed to Preview January 20, 2022 07:06 Inactive
@vercel vercel bot temporarily deployed to Preview March 9, 2022 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview March 9, 2022 01:00 Inactive
@vercel vercel bot temporarily deployed to Preview March 9, 2022 01:39 Inactive
@ken-futureverse ken-futureverse marked this pull request as ready for review March 13, 2022 21:22
@vercel vercel bot temporarily deployed to Preview March 13, 2022 21:29 Inactive
pages/_app.tsx Outdated Show resolved Hide resolved
@KarishmaBothara
Copy link
Collaborator

very nicely structured.. nice work

@vercel vercel bot temporarily deployed to Preview March 14, 2022 01:01 Inactive
@ken-futureverse
Copy link
Collaborator Author

@KarishmaBothara ready for round 2

  • Remove commented code plus all old codes
  • Avoid using .toHuman when getting collectionId
  • Bump @cennznet/api to 2.1.0-alpha.2

Copy link
Collaborator

@KarishmaBothara KarishmaBothara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ken-futureverse ken-futureverse merged commit ebc664b into main Mar 14, 2022
@ken-futureverse ken-futureverse deleted the refactor/phase-1 branch March 14, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment