-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cen 13988 add wkt to dicomseg recipe #26
Feature/cen 13988 add wkt to dicomseg recipe #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% certain if this recipe is usable without the source DCM file. Typically the DicomSeg files is loaded together with the source - that viewers can display the masks on top of pixel data.
It might be more useful to include an example source DCM file, or use Centaur API to retrieve the DCM file w/ any WKTs.
The code was failing for me until I manually created "output" directory.
I'll investigate and update accordingly, thanks Fima |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good, but please add the requirements.txt file so that anyone can run this notebook.
I would also ensure the dicomseg file loads along with the source DCM file into one of the open source viewers like 3dSlicer
Lynda, I followed instructions and installed from requirements.txt, but got these import errors in the notebook. Not sure if it is because I am on python 3.11 A module that was compiled using NumPy 1.x cannot be run in If you are a user of the module, the easiest solution will be to Traceback (most recent call last): File "", line 198, in _run_module_as_main
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apprving, but the imports did not work for me for some reason as is
gordonwade commented: For recipes in general, we want to have the most relaxed version constraints possible. Unless we have specific reasons to require a version (specific version, minimum version, etc.) we should remove those from the requirements file @lyndankwuda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does seem to work for me as-is, but I have some questions on streamling it.
This reverts commit 9553d12.
No description provided.