feat: add event provider for windows events #17
+181
−178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
A new column for the windows events CSV for Event provider data.
In the case of PowerShell event, I also duplicated the line to account for both PowerShell 7 and PowerShell 5. As they have different providers and it make sense to track both
A couple of notes for discussion and maybe further enhancement I can provide.
As I described here. Both EIDs 2004 and 2006 still exist in the
Microsoft-Windows-Windows Firewall With Advanced Security
log. But (at least in my testing) they've been replaced by EIDs 2071 and 2052 respectively.Another example would EIDs 6005 and 6006 related to the Event Log service. At least from testing these events no longer exist on modern version and are from older providers (I might be wrong but couldn't find them in the typical provider
Microsoft-Windows-Eventlog
(see here and here)These cases introduce an interesting challenge (while its rare). Maybe adding a windows version or another column called
Remarks
to mention these kind of issues when found. Imo this would be interesting.A final suggestion is I think its a good idea to include a
Channel
column as well. This would allow in the future to be more granular and maybe provide ETW relevant events that are generated in non enabled by default channels such as Analytic, Performance,...etc.Example would be in addition to EID 4688 from Security, maybe also mention EID 1 from the
Microsoft-Kernel-Process
which capture the same information. While users can't make use of it necessarily, it would help broaden the discussion around telemetry and raise awareness and can be used as a reference.Note: This PR closes #16