Skip to content

Commit

Permalink
Release v0.3.2
Browse files Browse the repository at this point in the history
  • Loading branch information
dpilafian committed Jul 17, 2021
1 parent a813b34 commit c8babcc
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 9 deletions.
1 change: 1 addition & 0 deletions dist/puppeteer-browser-ready.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export declare type StartWebServerOptions = {
folder?: string;
port?: number;
verbose?: boolean;
autoCleanup?: boolean;
};
export declare type Http = {
server: Server;
Expand Down
11 changes: 9 additions & 2 deletions dist/puppeteer-browser-ready.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ import httpTerminator from 'http-terminator';
// Package
const browserReady = {
log(...args) {
console.log(' [' + new Date().toISOString() + ']', ...args);
const indent = typeof globalThis['describe'] === 'function' ? ' [' : '[';
console.log(indent + new Date().toISOString() + ']', ...args);
},
startWebServer(options) {
const defaults = { folder: '.', port: 0, verbose: true };
const defaults = { folder: '.', port: 0, verbose: true, autoCleanup: true };
const settings = { ...defaults, ...options };
const server = express().use(express.static(settings.folder)).listen(settings.port);
const terminator = httpTerminator.createHttpTerminator({ server });
Expand All @@ -29,6 +30,12 @@ const browserReady = {
server.on('listening', () => done(http()));
if (settings.verbose)
server.on('listening', logListening).on('close', logClose);
const cleanup = () => {
console.log('[SIGINT]');
terminator.terminate();
};
if (settings.autoCleanup)
process.on('SIGINT', cleanup);
return new Promise(resolve => done = resolve);
},
shutdownWebServer(http) {
Expand Down
11 changes: 9 additions & 2 deletions dist/puppeteer-browser-ready.umd.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
// Package
const browserReady = {
log(...args) {
console.log(' [' + new Date().toISOString() + ']', ...args);
const indent = typeof globalThis['describe'] === 'function' ? ' [' : '[';
console.log(indent + new Date().toISOString() + ']', ...args);
},
startWebServer(options) {
const defaults = { folder: '.', port: 0, verbose: true };
const defaults = { folder: '.', port: 0, verbose: true, autoCleanup: true };
const settings = { ...defaults, ...options };
const server = express_1.default().use(express_1.default.static(settings.folder)).listen(settings.port);
const terminator = http_terminator_1.default.createHttpTerminator({ server });
Expand All @@ -44,6 +45,12 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
server.on('listening', () => done(http()));
if (settings.verbose)
server.on('listening', logListening).on('close', logClose);
const cleanup = () => {
console.log('[SIGINT]');
terminator.terminate();
};
if (settings.autoCleanup)
process.on('SIGINT', cleanup);
return new Promise(resolve => done = resolve);
},
shutdownWebServer(http) {
Expand Down
3 changes: 2 additions & 1 deletion hello-world/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

// To run:
// $ git clone https://github.com/center-key/puppeteer-browser-ready.git
// $ cd puppeteer-browser-ready
// $ cd hello-world
// $ npm install
// $ node index
// $ node index.js
// Hello, World!
// web fields: browser, page, response, url, status, statusText, html, $
// The HTML from https://pretty-print-json.js.org/ is 7556 characters
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "puppeteer-browser-ready",
"version": "0.3.1",
"version": "0.3.2",
"description": "Simple utility to go to a URL and wait for the HTTP response (written in TypeScript)",
"license": "MIT",
"type": "module",
Expand Down
2 changes: 1 addition & 1 deletion spec/combo-server-browser.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('Combo Server/Browser specification suite', () => {
/////////////////////////////////////////////////////////////////////////////////////
describe('The sample web page', () => {
let http; //fields: server, terminator, folder, url, port, verbose
let web; //fields: browser, page, response, title, html, $
let web; //fields: browser, page, response, location, title, html, $
before(async () => {
http = await browserReady.startWebServer(options);
web = await puppeteer.launch().then(browserReady.goto(http.url + webPath));
Expand Down
2 changes: 1 addition & 1 deletion spec/load-web-page.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { browserReady } from '../dist/puppeteer-browser-ready.js'; //replace wi

// Setup
const url = 'https://pretty-print-json.js.org/';
let web; //fields: browser, page, response, title, html, $
let web; //fields: browser, page, response, location, title, html, $
const loadWebPage = async () => web = await puppeteer.launch().then(browserReady.goto(url));
const closeWebPage = async () => await browserReady.close(web);

Expand Down
2 changes: 1 addition & 1 deletion spec/start-web-server.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Start Web Server specification suite', () => {

/////////////////////////////////////////////////////////////////////////////////////
describe('The sample web page', () => {
let web; //fields: browser, page, response, title, html, $
let web; //fields: browser, page, response, location, title, html, $
before(async () => web = await puppeteer.launch().then(browserReady.goto(http.url + webPath)));
after(async () => await browserReady.close(web));

Expand Down

0 comments on commit c8babcc

Please sign in to comment.