Skip to content

Commit

Permalink
Address new lint warning about logging an object
Browse files Browse the repository at this point in the history
error 'dom' will use Object's default stringification format ('[object Object]') when stringified
  • Loading branch information
dpilafian committed Jan 9, 2025
1 parent 577f766 commit 487e29c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion hello-world/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"assert-deep-strict-equal": "~1.2",
"fetch-json": "~3.3",
"jshint": "~2.13",
"mocha": "~10.7",
"mocha": "~11.0",
"server-listening": "~1.2"
}
}
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,25 +64,25 @@
"dependencies": {
"express": "~4.21",
"http-terminator": "~3.2",
"jsdom": "~25.0"
"jsdom": "~26.0"
},
"devDependencies": {
"@eslint/js": "~9.11",
"@eslint/js": "~9.17",
"@types/express": "~5.0",
"@types/jsdom": "~21.1",
"@types/node": "~22.7",
"@types/node": "~22.10",
"add-dist-header": "~1.4",
"assert-deep-strict-equal": "~1.2",
"copy-file-util": "~1.2",
"copy-folder-util": "~1.1",
"eslint": "~9.11",
"eslint": "~9.17",
"fetch-json": "~3.3",
"jshint": "~2.13",
"mocha": "~10.7",
"mocha": "~11.0",
"rimraf": "~6.0",
"run-scripts-util": "~1.3",
"typescript": "~5.6",
"typescript-eslint": "~8.7",
"typescript": "~5.7",
"typescript-eslint": "~8.19",
"w3c-html-validator": "~1.8"
}
}
2 changes: 1 addition & 1 deletion server-listening.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const serverListening = {
jsdomOnLoad(dom: JSDOM): Promise<JSDOM> {
const name = (<unknown>dom)?.constructor?.name;
if (name !== 'JSDOM')
throw new Error(`[server-listening] Unable to load DOM: ${String(dom)} => ${name}`);
throw new Error(`[server-listening] Unable to load DOM: ${String(<unknown>dom)} => ${name}`);
let done: (jsdom: JSDOM) => void;
dom.window.onload = () => done(dom);
return new Promise(resolve => done = resolve);
Expand Down

0 comments on commit 487e29c

Please sign in to comment.