rpc_from_geotiff fails if there is a textual RPC.txt next to the tiff #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitAronovitch
force-pushed
the
ikonos_with_rasterio
branch
from
3a74ff6
to
23012cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that if GDAL sees next to a geotiff
my_filename.tifa file namedmy_filename_RPC.txt, then it will read the RPC tags from it rather than the "RPC" tag that is stored inside the tiff...The problem is that the textual files (ikonos format) contain units, which
rpc_from_geotiffdoes not expect.So it fails with
This PR includes a regression test that demonstrates the problem, as well as a fix